public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Hamza Mahfooz <hamza.mahfooz@amd.com>,
	Javier Martinez Canillas <javierm@redhat.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] drm: DRM_WERROR should depend on DRM
Date: Thu, 28 Mar 2024 13:11:06 +0200	[thread overview]
Message-ID: <87jzlmfw6t.fsf@intel.com> (raw)
In-Reply-To: <87msqkhhts.fsf@intel.com>

On Tue, 26 Mar 2024, Jani Nikula <jani.nikula@intel.com> wrote:
> On Tue, 26 Mar 2024, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>> There is no point in asking the user about enforcing the DRM compiler
>> warning policy when configuring a kernel without DRM support.
>>
>> Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> D'oh! My bad.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

And pushed to drm-misc-next. Thanks for the patch!

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>> index f2bcf5504aa77679..2e1b23ccf30423a9 100644
>> --- a/drivers/gpu/drm/Kconfig
>> +++ b/drivers/gpu/drm/Kconfig
>> @@ -423,7 +423,7 @@ config DRM_PRIVACY_SCREEN
>>  
>>  config DRM_WERROR
>>  	bool "Compile the drm subsystem with warnings as errors"
>> -	depends on EXPERT
>> +	depends on DRM && EXPERT
>>  	default n
>>  	help
>>  	  A kernel build should not cause any compiler warnings, and this

-- 
Jani Nikula, Intel

      reply	other threads:[~2024-03-28 11:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 17:31 [PATCH] drm: DRM_WERROR should depend on DRM Geert Uytterhoeven
2024-03-26 17:31 ` Geert Uytterhoeven
2024-03-26 17:33 ` Geert Uytterhoeven
2024-03-26 20:13 ` Jani Nikula
2024-03-28 11:11   ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzlmfw6t.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=hamza.mahfooz@amd.com \
    --cc=javierm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox