From: Takashi Iwai <tiwai@suse.de>
To: "Jean-Loïc Charroud" <lagiraudiere+linux@free.fr>
Cc: Takashi Iwai <tiwai@suse.de>,
Stefan Binding <sbinding@opensource.cirrus.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
linux-sound <linux-sound@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
patches <patches@opensource.cirrus.com>
Subject: Re: [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD
Date: Wed, 07 Feb 2024 16:10:12 +0100 [thread overview]
Message-ID: <87jzng5mzv.wl-tiwai@suse.de> (raw)
In-Reply-To: <1366935939.585144512.1707316246651.JavaMail.zimbra@free.fr>
On Wed, 07 Feb 2024 15:30:46 +0100,
Jean-Loïc Charroud wrote:
>
> Fix device ID for "ASUS UM3402" and "ASUS UM6702RA/RC".
This change is only about the string in the table, not the actual
behavior, right? The name string there is only for debug info, so
it's no big problem even if it's not 100% right.
That is, this can be again split to another patch -- with the
additional Fixes tag to the commit that introduced the entries.
> Add DSD values for "ASUS UM3402" to cs35l41_config_table[].
... and this one is the mandatory fix for your device. It should be
the patch 1. Then we'll have two more, one for correcting the entry
names, and another for sorting the entries.
I'm a bit picky, but now you see how the things work.
Divide-and-conquer is the basic strategy.
Takashi
next prev parent reply other threads:[~2024-02-07 15:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 17:05 [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
2024-02-07 13:42 ` Takashi Iwai
2024-02-07 14:30 ` Jean-Loïc Charroud
2024-02-07 15:10 ` Takashi Iwai [this message]
2024-02-07 16:45 ` Jean-Loïc Charroud
2024-02-07 16:51 ` [PATCH] ALSA: hda/realtek: cs35l41: Fix device ID / model name Jean-Loïc Charroud
2024-02-07 17:10 ` Takashi Iwai
2024-02-07 18:05 ` Jean-Loïc Charroud
2024-02-07 17:48 ` [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD Jean-Loïc Charroud
2024-02-07 18:13 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzng5mzv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=lagiraudiere+linux@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox