From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B52C001DE for ; Tue, 25 Jul 2023 10:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233641AbjGYKcB (ORCPT ); Tue, 25 Jul 2023 06:32:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232900AbjGYKb7 (ORCPT ); Tue, 25 Jul 2023 06:31:59 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A915CE3; Tue, 25 Jul 2023 03:31:53 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 58CE421B1C; Tue, 25 Jul 2023 10:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690281112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dWo+Jm7Z/J00Cbkyh5PNtARF9DrmPfMqCwl8nGx+z2U=; b=2E6InrqrO0fh9B/S8gCc7r8uaPULJu6d9QonzUOqig3Tqrg4zeuY7l+cD/cGOGgu88lcey kUZHfG0/hn2fk6JKmcGosYlMVJIXwaP4rfbm23nDR7NT/7KFN5PzLM9BcVMAHyXpdWqysR i4TEyyaFCwk2DSFjE7z58B7T3maCk9w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690281112; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dWo+Jm7Z/J00Cbkyh5PNtARF9DrmPfMqCwl8nGx+z2U=; b=jpSzcBP8X5BN69Mp94riZKXN5aC0pds9VC0lrxN/V8rtzZVJiy0Dtxf8WjhHqm3IXjnDpd 73t15FnLNugR6sDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F02A613342; Tue, 25 Jul 2023 10:31:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id U4WHOZekv2ScfQAAMHmgww (envelope-from ); Tue, 25 Jul 2023 10:31:51 +0000 Date: Tue, 25 Jul 2023 12:31:51 +0200 Message-ID: <87jzuoth7s.wl-tiwai@suse.de> From: Takashi Iwai To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Tejun Heo , Takashi Iwai , Jaroslav Kysela , Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-kbuild@vger.kernel.org Subject: Re: [PATCH v2] um/drivers: Kconfig: fix hostaudio build errors In-Reply-To: <20230723215756.18307-1-rdunlap@infradead.org> References: <20230723215756.18307-1-rdunlap@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 23 Jul 2023 23:57:56 +0200, Randy Dunlap wrote: > > Use "select"s to ensure that the required kconfig symbols are set > as expected. > > This fixes build errors when CONFIG_SOUND is not set. > > ld: arch/um/drivers/hostaudio_kern.o: in function `hostaudio_cleanup_module': > hostaudio_kern.c:(.exit.text+0xa): undefined reference to `unregister_sound_mixer' > ld: hostaudio_kern.c:(.exit.text+0x15): undefined reference to `unregister_sound_dsp' > ld: arch/um/drivers/hostaudio_kern.o: in function `hostaudio_init_module': > hostaudio_kern.c:(.init.text+0x19): undefined reference to `register_sound_dsp' > ld: hostaudio_kern.c:(.init.text+0x31): undefined reference to `register_sound_mixer' > ld: hostaudio_kern.c:(.init.text+0x49): undefined reference to `unregister_sound_dsp' > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Fixes: d886e87cb82b ("sound: make OSS sound core optional") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Link: lore.kernel.org/r/202307141416.vxuRVpFv-lkp@intel.com > Cc: Richard Weinberger > Cc: Anton Ivanov > Cc: Johannes Berg > Cc: linux-um@lists.infradead.org > Cc: Tejun Heo > Cc: Takashi Iwai > Cc: Jaroslav Kysela > Cc: Masahiro Yamada > Cc: Nathan Chancellor > Cc: Nick Desaulniers > Cc: Nicolas Schier > Cc: linux-kbuild@vger.kernel.org > --- > v2: don't delete the HOSTAUDIO Kconfig entry (Masahiro) > > arch/um/drivers/Kconfig | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff -- a/arch/um/drivers/Kconfig b/arch/um/drivers/Kconfig > --- a/arch/um/drivers/Kconfig > +++ b/arch/um/drivers/Kconfig > @@ -111,20 +111,14 @@ config SSL_CHAN > > config UML_SOUND > tristate "Sound support" > + select SOUND > + select SOUND_OSS_CORE > help > This option enables UML sound support. If enabled, it will pull in > soundcore and the UML hostaudio relay, which acts as a intermediary > between the host's dsp and mixer devices and the UML sound system. > It is safe to say 'Y' here. > > -config SOUND > - tristate > - default UML_SOUND > - > -config SOUND_OSS_CORE > - bool > - default UML_SOUND > - > config HOSTAUDIO > tristate > default UML_SOUND And now essentially CONFIG_HOSTAUDIO is equal with CONFIG_UML_SOUND. Then isn't it better to replace CONFIG_HOSTAUDIO in arch/um/drivers/Makefile with CONFIG_UML_SOUND, so that you can drop CONFIG_HOSTAUDIO as well? thanks, Takashi