From: Takashi Iwai <tiwai@suse.de>
To: Stefan Binding <sbinding@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH v2 00/11] Fix support for System Suspend for CS35L41 HDA
Date: Mon, 24 Jul 2023 11:00:38 +0200 [thread overview]
Message-ID: <87jzupwuo9.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230721151816.2080453-1-sbinding@opensource.cirrus.com>
On Fri, 21 Jul 2023 17:18:05 +0200,
Stefan Binding wrote:
>
> There have been a couple of customer reports of intermittant issues after
> system resume, where sometimes the DSP firmware stops responding.
> Investigations into this issue show that there is a race between receiving
> a prepare from the HDA core, and the firmware reload which is started by
> the system resume. This can causes the Global Enable on the CS35L41 to be
> enabled during the firmware load, which can sometimes cause issues in the
> DSP.
>
> The existing system resume behaviour also did not resume the audio, if
> audio was previously playing when it was suspended.
> In addition, during investigation, it was found there were additional
> problems in the System Resume sequence, as well as the Playback sequence
> with External Boost, where the driver does not correctly follow its
> enable sequence for this mode. This can cause additional issues such as
> pops and clicks.
>
> This chain intends to correct the sequences for playback and system
> suspend/resume so that the driver: obeys the external boost enable sequence;
> resumes audio on system resume; and avoids the race condition on firmware
> load and playback during system resume.
>
> Changes since v1:
> - Split patch 1 into 2 separate patches
> - Combine Patches 6 and 9
>
> Stefan Binding (11):
> ALSA: cs35l41: Use mbox command to enable speaker output for external
> boost
> ALSA: cs35l41: Poll for Power Up/Down rather than waiting a fixed
> delay
> ALSA: hda: cs35l41: Check mailbox status of pause command after
> firmware load
> ALSA: hda: cs35l41: Ensure we correctly re-sync regmap before system
> suspending.
> ALSA: hda: cs35l41: Ensure we pass up any errors during system
> suspend.
> ALSA: hda: cs35l41: Move Play and Pause into separate functions
> ALSA: hda: hda_component: Add pre and post playback hooks to
> hda_component
> ALSA: hda: cs35l41: Use pre and post playback hooks
> ALSA: hda: cs35l41: Rework System Suspend to ensure correct call
> separation
> ALSA: hda: cs35l41: Add device_link between HDA and cs35l41_hda
> ALSA: hda: cs35l41: Ensure amp is only unmuted during playback
Applied all patches now to for-next branch.
thanks,
Takashi
next prev parent reply other threads:[~2023-07-24 9:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 15:18 [PATCH v2 00/11] Fix support for System Suspend for CS35L41 HDA Stefan Binding
2023-07-21 15:18 ` [PATCH v2 01/11] ALSA: cs35l41: Use mbox command to enable speaker output for external boost Stefan Binding
2023-07-21 15:18 ` [PATCH v2 02/11] ALSA: cs35l41: Poll for Power Up/Down rather than waiting a fixed delay Stefan Binding
2023-07-21 15:18 ` [PATCH v2 03/11] ALSA: hda: cs35l41: Check mailbox status of pause command after firmware load Stefan Binding
2023-07-21 15:18 ` [PATCH v2 04/11] ALSA: hda: cs35l41: Ensure we correctly re-sync regmap before system suspending Stefan Binding
2023-07-21 15:18 ` [PATCH v2 05/11] ALSA: hda: cs35l41: Ensure we pass up any errors during system suspend Stefan Binding
2023-07-21 15:18 ` [PATCH v2 06/11] ALSA: hda: cs35l41: Move Play and Pause into separate functions Stefan Binding
2023-07-21 15:18 ` [PATCH v2 07/11] ALSA: hda: hda_component: Add pre and post playback hooks to hda_component Stefan Binding
2023-07-21 15:18 ` [PATCH v2 08/11] ALSA: hda: cs35l41: Use pre and post playback hooks Stefan Binding
2023-07-21 15:18 ` [PATCH v2 09/11] ALSA: hda: cs35l41: Rework System Suspend to ensure correct call separation Stefan Binding
2023-07-21 15:18 ` [PATCH v2 10/11] ALSA: hda: cs35l41: Add device_link between HDA and cs35l41_hda Stefan Binding
2023-07-21 15:18 ` [PATCH v2 11/11] ALSA: hda: cs35l41: Ensure amp is only unmuted during playback Stefan Binding
2023-07-24 9:00 ` Takashi Iwai [this message]
2023-07-28 11:10 ` [PATCH v2 00/11] Fix support for System Suspend for CS35L41 HDA Takashi Iwai
2023-07-28 13:55 ` Stefan Binding
-- strict thread matches above, loose matches on Subject: below --
2023-09-01 16:48 Waldek Andrukiewicz
2023-09-01 16:51 ` Mark Brown
2023-09-01 16:57 ` Stefan Binding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzupwuo9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox