From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A91C7EE22 for ; Thu, 11 May 2023 17:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238706AbjEKRAM (ORCPT ); Thu, 11 May 2023 13:00:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238113AbjEKRAK (ORCPT ); Thu, 11 May 2023 13:00:10 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 561DBF2 for ; Thu, 11 May 2023 10:00:09 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 128C91FFC9; Thu, 11 May 2023 17:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683824408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n7C6XDQjjWqH6zu1WJqqlSe2OekATe0lWJfsYVoVucw=; b=B9KIjKsh2ChxWTXeCAD2nQLhoyYE+12jUFuP5NC0ksyHx9HK9KsjH1+I4SU8TboPGEK3V1 eiP+3BFmFCQujvz1B4X5qb6M/j7EBBbrXMlJrWtn+wvvPUsLPP6WPTldvr9mZ6aPb49DCm T1xb271FMiJefXqEEdqYnpF4MI/pH2k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683824408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n7C6XDQjjWqH6zu1WJqqlSe2OekATe0lWJfsYVoVucw=; b=8yB3Ky4v/YBlSkf08n2K/p8002VpZqUCvqfsZ21OL9w1m76NSJR5QYDAFe7zD9fWNecpuY QIufpXarSypuQcBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B8E43134B2; Thu, 11 May 2023 17:00:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aQ9CLBcfXWQkHQAAMHmgww (envelope-from ); Thu, 11 May 2023 17:00:07 +0000 Date: Thu, 11 May 2023 19:00:07 +0200 Message-ID: <87jzxeby7c.wl-tiwai@suse.de> From: Takashi Iwai To: Alexandru Sorodoc Cc: Jaroslav Kysela , Takashi Iwai , Stefan Binding , Tim Crawford , Andy Chi , Meng Tang , "Luke D. Jones" , Philipp Jungkamp , Kacper =?ISO-8859-2?Q?Michaj=B3ow?= , Yuchi Yang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ALSA: hda/realtek: Add quirks for ASUS GU604V and GU603V In-Reply-To: <20230511161510.315170-1-ealex95@gmail.com> References: <20230511161510.315170-1-ealex95@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2023 18:15:10 +0200, Alexandru Sorodoc wrote: > > These models use 2 CS35L41 amplifiers using SPI for down-facing > speakers. > > alc285_fixup_speaker2_to_dac1 is needed to fix volume control of the > down-facing speakers. > > Pin configs are needed to enable headset mic detection. > > Note that these models lack the ACPI _DSD properties needed to > initialize the amplifiers. They can be added during boot to get working > sound out of the speakers: > https://gist.github.com/lamperez/862763881c0e1c812392b5574727f6ff > > Signed-off-by: Alexandru Sorodoc > --- > v2: > Fixed position of quirk entries in table Thanks, applied now. Takashi