From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16E3C77B75 for ; Tue, 18 Apr 2023 09:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230244AbjDRJJ6 (ORCPT ); Tue, 18 Apr 2023 05:09:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbjDRJJv (ORCPT ); Tue, 18 Apr 2023 05:09:51 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7AEB7ED9 for ; Tue, 18 Apr 2023 02:09:34 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681808973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z6zePYgWahUe1cN6UNqkceIhZoYiRQILpLgWnkf2dr8=; b=yCLbL1vVSFZMlDyO07Q2de7KMgGnhCMrXGfTDsWvBg9aSXenylaPkL63VFPcI4mOtwkzjW Lf8delYt3FsmmGk5Cb5sk+iy1LmbgCujuh5sq602RMDp2gLNfIq3xXQ4YKK+WhNpT9KDPM BiFRAzuHWmHs3VTqTxBEDowObLxDwyWNsbEtdeIGiiA+Jk8dfVcx9B0TuQBVETdzW5Ggr2 DQA3wtlASrznyC5JkIXTWhUfEMSAiqmM+IkIYjc8pviQFj5yhz1KzmM46cJfAWPzXgwhBN W91m7t8thp81FK+ebIs9QNX3wXo0vkXCpGG91gZByAF1s5A3C2uQozoCnUWTrg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681808973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z6zePYgWahUe1cN6UNqkceIhZoYiRQILpLgWnkf2dr8=; b=0pjHP+xFlQiaBg9o0cxLedKC1Ez4ekeBsq4D9dq8RuOUnLo+WT5xVvwBWewInB+kFPPpjG TU8LYrHHJyEq4IAw== To: Frederic Weisbecker Cc: Victor Hassan , fweisbec@gmail.com, mingo@kernel.org, jindong.yue@nxp.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tick/broadcast: Do not set oneshot_mask except was_periodic was true In-Reply-To: <87mt354lr5.ffs@tglx> References: <20230412003425.11323-1-victor@allwinnertech.com> <87sfd0yi4g.ffs@tglx> <87mt354lr5.ffs@tglx> Date: Tue, 18 Apr 2023 11:09:32 +0200 Message-ID: <87jzy94kvn.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18 2023 at 10:50, Thomas Gleixner wrote: > On Mon, Apr 17 2023 at 17:02, Frederic Weisbecker wrote: >> Le Sat, Apr 15, 2023 at 11:01:51PM +0200, Thomas Gleixner a =C3=A9crit : >>> There is a second problem with broadcast device replacement in this >>> function. The broadcast device is only armed when the previous state of >>> the device was periodic. >> >> Any chance the patch could be cut in two then? > > Let me try. Not really as fixing that part depends on fixing the original issue and once the original issue is fixed the issue for the replacement case is more or less automatically there. Thanks, tglx