From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C8C0C7619A for ; Sat, 8 Apr 2023 10:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229669AbjDHKmA (ORCPT ); Sat, 8 Apr 2023 06:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbjDHKls (ORCPT ); Sat, 8 Apr 2023 06:41:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24A25113D7 for ; Sat, 8 Apr 2023 03:41:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93A82611A1 for ; Sat, 8 Apr 2023 10:39:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5C7EC433D2; Sat, 8 Apr 2023 10:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680950370; bh=PMR7OGvaOZO2q56kuA4FHiNMoQYG4vYI/XacVJ58yME=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EPqLcy+bw5POAs9FNRtOz6nqFcvTcKYLKk/ysdv3Bkuy2nBhbi6k/gKYaztPILPkq 5oIsRxvSWE9sSVxHq95y72j4sTRHOK3bRIFcxQLALDpfGZJf59TNVdUUoekBGoNVWq T3Q0WIhU30rx1LeMklSvcqgptQIB2muI/kOmz/PZKZCXzMJ2Yt8AHZr1PU0Ws/Gg9Z IsQRytBwRcON0onLUoZ0dQp7FDVDS8lwwwQREMu+55903cNRxRbyM+PbXDCVz4rBAB /HCnzqAAAvsprqxMnQlcwrEWGjaA/1dDH/fTIM3CpPLa6Av17SGfekIe4STUX0QFKu 3RuFN7k3D8wfA== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pl5yh-006u4Z-Jt; Sat, 08 Apr 2023 11:39:27 +0100 Date: Sat, 08 Apr 2023 11:39:27 +0100 Message-ID: <87jzym64kg.wl-maz@kernel.org> From: Marc Zyngier To: Vignesh Raghavendra Cc: Nishanth Menon , Tero Kristo , Santosh Shilimkar , Thomas Gleixner , , Subject: Re: [PATCH RFC v2 1/2] irqchip: irq-ti-sci-inta: Allocates VINTs at probe In-Reply-To: <20230327-irq-affinity-upstream-v2-1-1474e518f1cb@ti.com> References: <20230327-irq-affinity-upstream-v2-0-1474e518f1cb@ti.com> <20230327-irq-affinity-upstream-v2-1-1474e518f1cb@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: vigneshr@ti.com, nm@ti.com, kristo@kernel.org, ssantosh@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Mar 2023 16:04:26 +0100, Vignesh Raghavendra wrote: > > Simplify driver by allocating all VINTs at probe instead of > allocating on IRQ request. This will allow dedicating few VINTs as > direct IRQs without aggregation in future. I think this is going in the wrong direction. Eager allocation is wasting memory, slowing down boot, and in general a bad idea. Why can't you just pre-allocate *one* interrupt that serves as a chained handler for everything, and then use the rest of the interrupt space for "direct" interrupts? M. -- Without deviation from the norm, progress is not possible.