From: Takashi Iwai <tiwai@suse.de>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] ALSA: drivers: Remove the unused variable portman_read_data
Date: Sun, 19 Mar 2023 09:12:14 +0100 [thread overview]
Message-ID: <87jzzdma75.wl-tiwai@suse.de> (raw)
In-Reply-To: <87pm95mahe.wl-tiwai@suse.de>
On Sun, 19 Mar 2023 09:06:05 +0100,
Takashi Iwai wrote:
>
> On Fri, 17 Mar 2023 07:33:38 +0100,
> Jiapeng Chong wrote:
> >
> > Variable portman_read_data is not effectively used, so delete it.
> >
> > sound/drivers/portman2x4.c:195:18: warning: unused function 'portman_read_data'.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4557
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> Thanks, applied now.
... and now I see Tom's patch removing one more unused one, so I took
Tom's fix instead of yours.
https://lore.kernel.org/r/20230318135229.1685266-1-trix@redhat.com
thanks,
Takashi
prev parent reply other threads:[~2023-03-19 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 6:33 [PATCH] ALSA: drivers: Remove the unused variable portman_read_data Jiapeng Chong
2023-03-19 8:06 ` Takashi Iwai
2023-03-19 8:12 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzzdma75.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=abaci@linux.alibaba.com \
--cc=alsa-devel@alsa-project.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox