From: Jonathan Corbet <corbet@lwn.net>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Documentation/features-refresh.sh: Only sed the beginning "arch" of ARCH_DIR
Date: Mon, 05 Dec 2022 03:02:18 -0700 [thread overview]
Message-ID: <87k036mamt.fsf@meer.lwn.net> (raw)
In-Reply-To: <1670156327-9631-2-git-send-email-yangtiezhu@loongson.cn>
Tiezhu Yang <yangtiezhu@loongson.cn> writes:
> It should only sed the beginning "arch" of ARCH_DIR in features-refresh.sh,
> otherwise loongarch is recognized as loong, that is not what we want.
>
> Fixes: be99f610a110 ("Documentation/features: Add script that refreshes the arch support status files in place")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> Documentation/features/scripts/features-refresh.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/features/scripts/features-refresh.sh b/Documentation/features/scripts/features-refresh.sh
> index 9e72d38..c228812 100755
> --- a/Documentation/features/scripts/features-refresh.sh
> +++ b/Documentation/features/scripts/features-refresh.sh
> @@ -60,7 +60,7 @@ for F_FILE in Documentation/features/*/*/arch-support.txt; do
> echo " | arch |status|" >> $T_FILE
> echo " -----------------------" >> $T_FILE
> for ARCH_DIR in arch/*/; do
> - ARCH=$(echo $ARCH_DIR | sed -e 's/arch//g' | sed -e 's/\///g')
> + ARCH=$(echo $ARCH_DIR | sed -e 's/^arch//g' | sed -e 's/\///g')
So ... looking at this now, it strikes me as a bit of a convoluted way
to reimplement "basename" - obviously incorrectly before this fix. Oh
well, this is better than before, so I've applied the series.
Thanks,
jon
next prev parent reply other threads:[~2022-12-05 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 12:18 [PATCH 0/2] docs: Correct the arch name of LoongArch Tiezhu Yang
2022-12-04 12:18 ` [PATCH 1/2] Documentation/features-refresh.sh: Only sed the beginning "arch" of ARCH_DIR Tiezhu Yang
2022-12-05 10:02 ` Jonathan Corbet [this message]
2022-12-04 12:18 ` [PATCH 2/2] Documentation/features: Use loongarch instead of loong Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k036mamt.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox