From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93248C433FE for ; Mon, 28 Nov 2022 13:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231843AbiK1NyV (ORCPT ); Mon, 28 Nov 2022 08:54:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232083AbiK1NyP (ORCPT ); Mon, 28 Nov 2022 08:54:15 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D415DCF for ; Mon, 28 Nov 2022 05:54:15 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C99761F891; Mon, 28 Nov 2022 13:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669643653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ipsGjAePSRWQXHePTdUHAIDQwEp3fqNPEG6d13olGuU=; b=Ez8FpgEMmZydvO7wPLGZWGYJeNVle+MHyzILf5gQ/KAn6ar+vf1LMZ6H8fTBUo+hBSbV6/ zBXoOCFjU+nXZTeHVqfnQvNETiPG9Ok2joCO86Bet+8FAxrG9UzvmTGvRMV7wLlzz1phLc FrjhnE7EBqJ83YgSfgO86g7a14gXxDA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669643653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ipsGjAePSRWQXHePTdUHAIDQwEp3fqNPEG6d13olGuU=; b=TxkGB6Dy1k+Sv/wrLAy+xPkU8vBC16BDJeNNLyUyvZG7AhKs+e369wlvpxNIXUPq150sIU g2Egsk7ln+M07XAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AAA0F1326E; Mon, 28 Nov 2022 13:54:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EEtTKIW9hGNrFAAAMHmgww (envelope-from ); Mon, 28 Nov 2022 13:54:13 +0000 Date: Mon, 28 Nov 2022 14:54:13 +0100 Message-ID: <87k03fyyka.wl-tiwai@suse.de> From: Takashi Iwai To: Liu Shixin Cc: Jaroslav Kysela , Takashi Iwai , , Subject: Re: [PATCH] ALSA: asihpi: fix missing pci_disable_device() In-Reply-To: <20221126021429.3029562-1-liushixin2@huawei.com> References: <20221126021429.3029562-1-liushixin2@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Nov 2022 03:14:29 +0100, Liu Shixin wrote: > > pci_disable_device() need be called while module exiting, switch to use > pcim_enable(), pci_disable_device() will be called in pcim_release(). > > Fixes: 3285ea10e9b0 ("ALSA: asihpi - Interrelated HPI tidy up.") > Signed-off-by: Liu Shixin Thanks, applied now. Takashi