Re: [PATCH v3 2/3] arm64: dts: marvell: espressobin-ultra: add PHY and switch reset pins

Gregory CLEMENT
2022-05-09T09:34:21Z

Robert Marko <robert.marko@sartura.hr> writes:

> Both the Topaz switch and 88E1512 PHY have their reset and interrupts
> connected to the SoC.
>
> So, define the Topaz and 88E1512 reset pins in the DTS.
>
> Defining the interrupt pins wont work as both the 88E1512 and the
> Topaz switch uses active LOW IRQ signals but the A37xx GPIO controller
> only supports edge triggers.
> 88E1512 would require special setup anyway as its INT pin is shared with
> the LED2 and you first need to configure it as INT.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Applied on mvebu/dt64

Thanks,

Gregory

> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index 610ff6f385c7..7c786d218f1b 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -114,12 +114,16 @@ &usb3 {
> &mdio {
> extphy: ethernet-phy@1 {
> reg = <1>;
> +
> + reset-gpios = <&gpionb 2 GPIO_ACTIVE_LOW>;
> };
> };
>
> &switch0 {
> reg = <3>;
>
> + reset-gpios = <&gpiosb 23 GPIO_ACTIVE_LOW>;
> +
> ports {
> switch0port1: port@1 {
> reg = <1>;
> --
> 2.31.1
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering