From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0F8C47094 for ; Thu, 10 Jun 2021 08:06:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05F89613F1 for ; Thu, 10 Jun 2021 08:06:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbhFJIIU (ORCPT ); Thu, 10 Jun 2021 04:08:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:40030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbhFJIIS (ORCPT ); Thu, 10 Jun 2021 04:08:18 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E7E57613ED; Thu, 10 Jun 2021 08:06:22 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lrFhk-006gKO-U5; Thu, 10 Jun 2021 09:06:21 +0100 Date: Thu, 10 Jun 2021 09:06:19 +0100 Message-ID: <87k0n2qh38.wl-maz@kernel.org> From: Marc Zyngier To: Heiner Kallweit Cc: Thomas Gleixner , Linux Kernel Mailing List , "linux-nvme@lists.infradead.org" , Christoph Hellwig Subject: Re: linux-next: NVME using PCI legacy interrupts only In-Reply-To: <52371274-20bc-a150-a3ed-ba3e1305ad3e@gmail.com> References: <52371274-20bc-a150-a3ed-ba3e1305ad3e@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: hkallweit1@gmail.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, hch@lst.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 Jun 2021 19:43:57 +0100, Heiner Kallweit wrote: > > I found that on linux-next from June 8th my nvme disk is using legacy > interrupts only. Some debugging lead me to irq_find_mapping() in > msi_domain_alloc() returning -EEXIST. > > The nvme core first allocates a MSI-X interrupt for setup purposes > and later frees it and allocates the final number of MSI-X interrupts. > > The following experimental change brought back the MSI-X interrupts. > This makes me think that somehow freeing a MSI-X interrupt doesn't > free it completely. I didn't see this behavior a few days ago, > therefore I think it's related to the recent changes to > irqdomain/genirq. > > Didn't do a bisect yet, maybe you have an idea already. Yeah, recent changes in the irqdomain subsystem seem to have uncovered a long standing issue where we are leaving dangling references in some domains.... I've now dropped the branch from -next while I figure it out. Thanks, M. -- Without deviation from the norm, progress is not possible.