From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8E7C433B4 for ; Thu, 15 Apr 2021 08:11:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9673561158 for ; Thu, 15 Apr 2021 08:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231561AbhDOILs convert rfc822-to-8bit (ORCPT ); Thu, 15 Apr 2021 04:11:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:55664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231535AbhDOILr (ORCPT ); Thu, 15 Apr 2021 04:11:47 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F3B6960FEA; Thu, 15 Apr 2021 08:11:24 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lWx5t-007agq-Ny; Thu, 15 Apr 2021 09:11:21 +0100 Date: Thu, 15 Apr 2021 09:11:21 +0100 Message-ID: <87k0p4m0gm.wl-maz@kernel.org> From: Marc Zyngier To: Kever Yang Cc: Peter Geis , Thomas Gleixner , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , Heiko =?UTF-8?B?U3Q=?= =?UTF-8?B?w7xibmVy?= Subject: Re: [RFC] ITS fails to allocate on rk3568/rk3566 In-Reply-To: <678e9950-dd85-abb2-a104-07a4db1fad49@rock-chips.com> References: <871rbeo7wf.wl-maz@kernel.org> <87y2dmmggt.wl-maz@kernel.org> <87tuoambdb.wl-maz@kernel.org> <871rbdt4tu.wl-maz@kernel.org> <678e9950-dd85-abb2-a104-07a4db1fad49@rock-chips.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: kever.yang@rock-chips.com, pgwipeout@gmail.com, tglx@linutronix.de, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, heiko@sntech.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kever, On Thu, 15 Apr 2021 08:24:33 +0100, Kever Yang wrote: > > Hi Marc, Peter, > >     RK356x GIC has two issues: > > 1. GIC only support 32bit address while rk356x supports 8GB DDR SDRAM, > so we use ZONE_DMA32 to fix this issue; What transactions does this affect exactly? Only some ITS tables? Or all of them, including the command queue? What about the configuration and pending tables associated with the redistributors? > 2. GIC version is r1p6-00rel0, RK356x interconnect does not support > GIC and CPU snoop to each other, hence the GIC does not support the > shareability feature.  The read of register value for shareability  > feature does not return as expect in GICR and GITS, so we have to > workaround for it. How about the cacheability attribute? Can you please provide the exact set of attributes that this system actually supports for each of the ITS and redistributor base registers? Also, please provide errata numbers for these two issues so that we can properly document them and track the workarounds. Thanks, M. -- Without deviation from the norm, progress is not possible.