From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B480C433DB for ; Tue, 26 Jan 2021 12:40:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E430A230FE for ; Tue, 26 Jan 2021 12:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391522AbhAZMjx (ORCPT ); Tue, 26 Jan 2021 07:39:53 -0500 Received: from a1.mail.mailgun.net ([198.61.254.60]:29000 "EHLO a1.mail.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403947AbhAZKO4 (ORCPT ); Tue, 26 Jan 2021 05:14:56 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1611656076; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=VJRxFY8ci75sUTvygaKMgJ009Mw8EC58s0wPRv5AOG4=; b=sg9K5K++x9iIJUzz9DpNVA+cLYsVU+F7uGibpNdh7/XIlEMyo9z3IEeSpphV07DKiwtLWKly D9OI1RbyaHHKa5Eyw/3I9QC9/g5qLWezSQnoyXPq5Z37lNK0MqdcxKHAkmPkmoZ4HRBP6I6G HA/HcyoPpGLFv6dG7v74sopJtQE= X-Mailgun-Sending-Ip: 198.61.254.60 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 600feb712c36b2106d36caa7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 26 Jan 2021 10:14:09 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id F1352C43461; Tue, 26 Jan 2021 10:14:08 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 89D80C433C6; Tue, 26 Jan 2021 10:14:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 89D80C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Manivannan Sadhasivam Cc: hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org, Carl Huang , ath11k@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mhi: use irq_flags if controller driver configures it References: <20210104101128.8217-1-cjhuang@codeaurora.org> <20210104170359.GE2256@work> <87o8hti8t8.fsf@codeaurora.org> <20210121075242.GB30041@thinkpad> Date: Tue, 26 Jan 2021 12:14:04 +0200 In-Reply-To: <20210121075242.GB30041@thinkpad> (Manivannan Sadhasivam's message of "Thu, 21 Jan 2021 13:22:42 +0530") Message-ID: <87k0s0atub.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Manivannan Sadhasivam writes: > On Wed, Jan 13, 2021 at 09:40:19AM +0200, Kalle Valo wrote: >> Manivannan Sadhasivam writes: >> >> > On Mon, Jan 04, 2021 at 06:11:28PM +0800, Carl Huang wrote: >> >> If controller driver has specified the irq_flags, mhi uses this specified >> >> irq_flags. Otherwise, mhi uses default irq_flags. >> >> >> >> The purpose of this change is to support one MSI vector for QCA6390. >> >> MHI will use one same MSI vector too in this scenario. >> >> >> >> In case of one MSI vector, IRQ_NO_BALANCING is needed when irq handler >> >> is requested. The reason is if irq migration happens, the msi_data may >> >> change too. However, the msi_data is already programmed to QCA6390 >> >> hardware during initialization phase. This msi_data inconsistence will >> >> result in crash in kernel. >> >> >> >> Another issue is in case of one MSI vector, IRQF_NO_SUSPEND will trigger >> >> WARNINGS because QCA6390 wants to disable the IRQ during the suspend. >> >> >> >> To avoid above two issues, QCA6390 driver specifies the irq_flags in case >> >> of one MSI vector when mhi_register_controller is called. >> >> >> >> Signed-off-by: Carl Huang >> >> Reviewed-by: Manivannan Sadhasivam >> > >> > Applied to mhi-next! >> >> Would it be possible again to have an immutable branch for this commit? >> We need it for implementing one MHI support to ath11k[1] required by >> Dell XPS 13 9310 laptops, which a lot of people are waiting. Otherwise I >> can only apply the feature for v5.13, which will be released on July. >> > > Dropped this patch from mhi-next and applied to mhi-ath11k-immutable branch: > https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-ath11k-immutable > > This branch will also be merged into mhi-next. Thanks a lot! And Greg will also pull this directly so that commit ids won't change? Just trying to avoid conflicts between ath and mhi trees as much as possible. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches