* [PATCH] fatfs: switch write_lock to read_lock in fat_ioctl_get_attributes
@ 2020-06-28 1:34 fengyubo
2020-06-30 10:59 ` OGAWA Hirofumi
0 siblings, 1 reply; 2+ messages in thread
From: fengyubo @ 2020-06-28 1:34 UTC (permalink / raw)
To: hirofumi; +Cc: fangwei1, fengyubo3, linux-kernel
From: Yubo Feng <fengyubo3@huawei.com>
There is no necessery to hold write_lock in fat_ioctl_get_attributes.
write_lock may make an impact on concurrency of fat_ioctl_get_attributes.
Signed-off-by: Yubo Feng <fengyubo3@huawei.com>
---
fs/fat/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/fat/file.c b/fs/fat/file.c
index 42134c5..f9ee27c 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -25,9 +25,9 @@ static int fat_ioctl_get_attributes(struct inode *inode, u32 __user *user_attr)
{
u32 attr;
- inode_lock(inode);
+ inode_lock_shared(inode);
attr = fat_make_attrs(inode);
- inode_unlock(inode);
+ inode_unlock_shared(inode);
return put_user(attr, user_attr);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fatfs: switch write_lock to read_lock in fat_ioctl_get_attributes
2020-06-28 1:34 [PATCH] fatfs: switch write_lock to read_lock in fat_ioctl_get_attributes fengyubo
@ 2020-06-30 10:59 ` OGAWA Hirofumi
0 siblings, 0 replies; 2+ messages in thread
From: OGAWA Hirofumi @ 2020-06-30 10:59 UTC (permalink / raw)
To: Andrew Morton; +Cc: fengyubo, fangwei1, linux-kernel
fengyubo <fengyubo3@huawei.com> writes:
> From: Yubo Feng <fengyubo3@huawei.com>
>
> There is no necessery to hold write_lock in fat_ioctl_get_attributes.
> write_lock may make an impact on concurrency of fat_ioctl_get_attributes.
>
> Signed-off-by: Yubo Feng <fengyubo3@huawei.com>
Looks good.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> fs/fat/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/file.c b/fs/fat/file.c
> index 42134c5..f9ee27c 100644
> --- a/fs/fat/file.c
> +++ b/fs/fat/file.c
> @@ -25,9 +25,9 @@ static int fat_ioctl_get_attributes(struct inode *inode, u32 __user *user_attr)
> {
> u32 attr;
>
> - inode_lock(inode);
> + inode_lock_shared(inode);
> attr = fat_make_attrs(inode);
> - inode_unlock(inode);
> + inode_unlock_shared(inode);
>
> return put_user(attr, user_attr);
> }
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-30 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-28 1:34 [PATCH] fatfs: switch write_lock to read_lock in fat_ioctl_get_attributes fengyubo
2020-06-30 10:59 ` OGAWA Hirofumi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox