Re: [patch V4 part 3 04/29] x86/traps: Make interrupt enable/disable symmetric in C code

Andy Lutomirski
2020-05-09T00:44:41Z

On Tue, May 5, 2020 at 7:15 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Traps enable interrupts conditionally but rely on the ASM return code to
> disable them again. That results in redundant interrupt disable and trace
> calls.
>
> Make the trap handlers disable interrupts before returning to avoid that,
> which allows simplification of the ASM entry code.

Acked-by: Andy Lutomirski <luto@kernel.org>

And thanks! This has bothered me forever.