From: NeilBrown <neilb@suse.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Sergei Turchanov <turchanov@farpost.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: seq_file: fix problem when seeking mid-record.
Date: Mon, 05 Aug 2019 20:08:41 +1000 [thread overview]
Message-ID: <87k1brkjpy.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <4862a29d-7e4f-5bc5-dcde-ec9ebafa1ff2@web.de>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
On Mon, Aug 05 2019, Markus Elfring wrote:
>> Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code
>> and interface")
>
> Please do not split this tag across multiple lines in the final commit description.
I tend to agree...
I had previously seen
"Possible unwrapped commit description (prefer a maximum 75 chars per line)\n"
warnings from checkpatch, but one closer look that doesn't apply to
Fixes: lines (among other special cases).
Maybe Andrew will fix it up for me when it applies .... (please!)
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-08-05 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 6:16 [BUG] lseek on /proc/meminfo is broken in 4.19.59 Sergei Turchanov
2019-08-01 7:11 ` Gao Xiang
2019-08-01 7:52 ` Sergei Turchanov
2019-08-01 8:09 ` [BUG] lseek on /proc/meminfo is broken in 4.19.59 maybe due to commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface") Sergei Turchanov
2019-08-01 9:14 ` NeilBrown
2019-08-02 1:40 ` Sergei Turchanov
2019-08-05 4:26 ` [PATCH] seq_file: fix problem when seeking mid-record NeilBrown
2019-08-05 9:15 ` Markus Elfring
2019-08-05 10:08 ` NeilBrown [this message]
2019-08-06 22:42 ` [PATCH] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1brkjpy.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=turchanov@farpost.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).