From: Kalle Valo <kvalo@codeaurora.org>
To: Kangjie Lu <kjlu@umn.edu>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
pakki001@umn.edu, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: ath: fix missing checks for bmi reads and writes
Date: Fri, 26 Apr 2019 14:51:51 +0300 [thread overview]
Message-ID: <87k1fhugq0.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190315051903.10664-1-kjlu@umn.edu> (Kangjie Lu's message of "Fri, 15 Mar 2019 00:19:03 -0500")
Kangjie Lu <kjlu@umn.edu> writes:
> ath10k_bmi_write32 and ath10k_bmi_read32 can fail. The fix
> checks their statuses to avoid potential undefined behaviors.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
[...]
> @@ -2500,8 +2515,15 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode,
> if (status)
> goto err;
>
> - if (ar->hif.bus == ATH10K_BUS_SDIO)
> - ath10k_init_sdio(ar);
> + if (ar->hif.bus == ATH10K_BUS_SDIO) {
> + status = ath10k_init_sdio(ar);
> + if (status) {
> + ath10k_err(ar,
> + "could not init HTC (%d)\n",
> + status);
I'll fix the warning message as well, we are not initialisating HTC
here.
--
Kalle Valo
next prev parent reply other threads:[~2019-04-26 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 5:19 [PATCH] net: ath: fix missing checks for bmi reads and writes Kangjie Lu
2019-03-15 5:24 ` Kalle Valo
2019-04-26 11:51 ` Kalle Valo [this message]
2019-09-23 8:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1fhugq0.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox