From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBBECC43381 for ; Thu, 28 Mar 2019 17:25:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4BF02173C for ; Thu, 28 Mar 2019 17:25:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726266AbfC1RZ0 convert rfc822-to-8bit (ORCPT ); Thu, 28 Mar 2019 13:25:26 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34473 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfC1RZ0 (ORCPT ); Thu, 28 Mar 2019 13:25:26 -0400 X-Originating-IP: 109.213.38.144 Received: from localhost (alyon-652-1-47-144.w109-213.abo.wanadoo.fr [109.213.38.144]) (Authenticated sender: gregory.clement@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 0AF74FF80E; Thu, 28 Mar 2019 17:25:14 +0000 (UTC) From: Gregory CLEMENT To: Rob Herring Cc: Stephen Boyd , Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Antoine Tenart , =?utf-8?Q?Miqu=C3=A8l?= Raynal , Maxime Chevallier Subject: Re: [PATCH v4 1/6] dt-bindings: ap806: add the cluster clock node in the syscon file In-Reply-To: <20190328171350.GA26680@bogus> References: <20190325124803.28904-1-gregory.clement@bootlin.com> <20190325124803.28904-2-gregory.clement@bootlin.com> <20190328171350.GA26680@bogus> Date: Thu, 28 Mar 2019 18:25:14 +0100 Message-ID: <87k1gioqrp.fsf@FE-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On jeu., mars 28 2019, Rob Herring wrote: > On Mon, Mar 25, 2019 at 01:47:58PM +0100, Gregory CLEMENT wrote: >> Document the device tree binding for the cluster clock controllers found >> in the Armada 7K/8K SoCs. >> >> Signed-off-by: Gregory CLEMENT >> --- >> .../arm/marvell/ap806-system-controller.txt | 25 +++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt >> index 7b8b8eb0191f..ceeba18b4ac3 100644 >> --- a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt >> +++ b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt >> @@ -143,3 +143,28 @@ ap_syscon1: system-controller@6f8000 { >> #thermal-sensor-cells = <1>; >> }; >> }; >> + >> +Cluster clocks: >> +--------------- >> + >> +Device Tree Clock bindings for cluster clock of AP806 Marvell. Each >> +cluster contain up to 2 CPUs running at the same frequency. >> + >> +Required properties: >> +- compatible: must be "marvell,ap806-cpu-clock"; >> +- #clock-cells : should be set to 1. >> +- clocks : shall be the input parents clock phandle for the clock. >> + >> +Optional property: >> + - reg: register range associated the cluser clocks > > reg can be optional to use, but should either be there or not. OK so let's remove it! Thanks, Grégory > > And there's a typo. > >> + >> +ap_syscon1: system-controller@6f8000 { >> + compatible = "syscon", "simple-mfd"; >> + reg = <0x6f8000 0x1000>; >> + >> + cpu_clk: clock-cpu { >> + compatible = "marvell,ap806-cpu-clock"; >> + clocks = <&ap_clk 0>, <&ap_clk 1>; >> + #clock-cells = <1>; >> + }; >> +}; >> -- >> 2.20.1 >> -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com