From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934862AbdEVOhS (ORCPT ); Mon, 22 May 2017 10:37:18 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:44081 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934639AbdEVOhO (ORCPT ); Mon, 22 May 2017 10:37:14 -0400 From: Gregory CLEMENT To: Paul Gortmaker Cc: Linus Walleij , linux-gpio@vger.kernel.org, LKML , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , "linux-arm-kernel\@lists.infradead.org" , Rob Herring , devicetree@vger.kernel.org, Russell King , Nadav Haklai , Kostya Porotchkin , Neta Zur Hershkovits , Marcin Wojtas , Omri Itach , Shadi Ammouri , Hanna Hawa Subject: Re: [PATCH 7/9] pinctrl: mvebu: add driver for Armada AP806 pinctrl References: <5a190d4d71cb8626315b832c6f987e9e03da2fa9.1495209664.git-series.gregory.clement@free-electrons.com> Date: Mon, 22 May 2017 16:37:12 +0200 In-Reply-To: (Paul Gortmaker's message of "Sat, 20 May 2017 15:04:22 -0400") Message-ID: <87k2590xgn.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On sam., mai 20 2017, Paul Gortmaker wrote: > On Fri, May 19, 2017 at 12:04 PM, Gregory CLEMENT > wrote: >> From: Hanna Hawa >> >> This commit adds a pinctrl driver for the pin-muxing controller found in >> the AP806 part of the Marvell Armada 7K and 8K SoCs. Its register >> interface is compatible with the one used by previous mvebu pin >> controllers, so the common logic in drivers/pinctrl/mvebu/pinctrl-mvebu.c >> is used. >> >> Signed-off-by: Hanna Hawa >> Reviewed-by: Shadi Ammouri >> [updated for mvebu pinctrl changes >> - converted to simple_mmio >> - removed unimplemented .remove function >> - removed DTS description >> - converted to use syscon/regmap >> --rmk] >> Signed-off-by: Russell King >> Reviewed-by: Thomas Petazzoni >> Signed-off-by: Gregory CLEMENT >> --- >> drivers/pinctrl/mvebu/Kconfig | 4 +- >> drivers/pinctrl/mvebu/Makefile | 1 +- >> drivers/pinctrl/mvebu/pinctrl-armada-ap806.c | 145 ++++++++++++++++++++- >> 3 files changed, 150 insertions(+) >> create mode 100644 drivers/pinctrl/mvebu/pinctrl-armada-ap806.c >> >> diff --git a/drivers/pinctrl/mvebu/Kconfig b/drivers/pinctrl/mvebu/Kconfig >> index 8cb444b60ae9..0e0b009f2b71 100644 >> --- a/drivers/pinctrl/mvebu/Kconfig >> +++ b/drivers/pinctrl/mvebu/Kconfig >> @@ -28,6 +28,10 @@ config PINCTRL_ARMADA_39X >> bool >> select PINCTRL_MVEBU >> >> +config PINCTRL_ARMADA_AP806 >> + bool >> + select PINCTRL_MVEBU > > If this isn't going to be modular, can we remove all the uses > of module.h and MODULE_ etc. I've nearly got all of these > cleaned up in pinctrl and it would be nice to not have new > ones creep back in. Indeed it won't be modular, so I will remove it in this driver and the next one. Thanks, Gregory > > Thanks, > Paul. > -- > >> + >> config PINCTRL_ARMADA_XP >> bool >> select PINCTRL_MVEBU >> diff --git a/drivers/pinctrl/mvebu/Makefile b/drivers/pinctrl/mvebu/Makefile >> index 60c245a60f39..455db274b53d 100644 >> --- a/drivers/pinctrl/mvebu/Makefile >> +++ b/drivers/pinctrl/mvebu/Makefile >> @@ -5,6 +5,7 @@ obj-$(CONFIG_PINCTRL_ARMADA_370) += pinctrl-armada-370.o >> obj-$(CONFIG_PINCTRL_ARMADA_375) += pinctrl-armada-375.o >> obj-$(CONFIG_PINCTRL_ARMADA_38X) += pinctrl-armada-38x.o >> obj-$(CONFIG_PINCTRL_ARMADA_39X) += pinctrl-armada-39x.o >> +obj-$(CONFIG_PINCTRL_ARMADA_AP806) += pinctrl-armada-ap806.o >> obj-$(CONFIG_PINCTRL_ARMADA_XP) += pinctrl-armada-xp.o >> obj-$(CONFIG_PINCTRL_ARMADA_37XX) += pinctrl-armada-37xx.o >> obj-$(CONFIG_PINCTRL_ORION) += pinctrl-orion.o >> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-ap806.c b/drivers/pinctrl/mvebu/pinctrl-armada-ap806.c >> new file mode 100644 >> index 000000000000..269b1c1f53b1 >> --- /dev/null >> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-ap806.c >> @@ -0,0 +1,145 @@ >> +/* >> + * Marvell Armada ap806 pinctrl driver based on mvebu pinctrl core >> + * >> + * Copyright (C) 2017 Marvell >> + * >> + * Thomas Petazzoni >> + * Hanna Hawa >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + */ >> + >> +#include >> +#include >> +#include >> +#include > > [...] > >> +module_platform_driver(armada_ap806_pinctrl_driver); >> + >> +MODULE_AUTHOR("Thomas Petazzoni "); >> +MODULE_DESCRIPTION("Marvell Armada ap806 pinctrl driver"); >> +MODULE_LICENSE("GPL v2"); >> -- >> git-series 0.9.1 -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com