From: Kalle Valo <kvalo@codeaurora.org>
To: "Reshetova\, Elena" <elena.reshetova@intel.com>
Cc: "netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rdma\@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-hams\@vger.kernel.org" <linux-hams@vger.kernel.org>,
"linux-ppp\@vger.kernel.org" <linux-ppp@vger.kernel.org>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"ganeshgr\@chelsio.com" <ganeshgr@chelsio.com>,
"nbd\@openwrt.org" <nbd@openwrt.org>,
"blogic\@openwrt.org" <blogic@openwrt.org>,
"matthias.bgg\@gmail.com" <matthias.bgg@gmail.com>,
"yishaih\@mellanox.com" <yishaih@mellanox.com>,
"saeedm\@mellanox.com" <saeedm@mellanox.com>,
"matanb\@mellanox.com" <matanb@mellanox.com>,
"leonro\@mellanox.com" <leonro@mellanox.com>,
"ajk\@comnets.uni-bremen.de" <ajk@comnets.uni-bremen.de>,
"paulus\@samba.org" <paulus@samba.org>, "j\@w1.fi" <j@w1.fi>,
"peterz\@infradead.org" <peterz@infradead.org>,
"keescook\@chromium.org" <keescook@chromium.org>,
"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Hans Liljestrand <ishkamiel@gmail.com>,
David Windsor <dwindsor@gmail.com>
Subject: Re: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t
Date: Wed, 05 Apr 2017 13:33:12 +0300 [thread overview]
Message-ID: <87k26zi1p3.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B41C8741B@IRSMSX102.ger.corp.intel.com> (Elena Reshetova's message of "Tue, 4 Apr 2017 10:07:55 +0000")
"Reshetova, Elena" <elena.reshetova@intel.com> writes:
>> Elena Reshetova <elena.reshetova@intel.com> writes:
>>
>> > refcount_t type and corresponding API should be
>> > used instead of atomic_t when the variable is used as
>> > a reference counter. This allows to avoid accidental
>> > refcounter overflows that might lead to use-after-free
>> > situations.
>> >
>> > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
>> > Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
>> > Signed-off-by: Kees Cook <keescook@chromium.org>
>> > Signed-off-by: David Windsor <dwindsor@gmail.com>
>> > ---
>> > drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 15 ++++++++-------
>> > 1 file changed, 8 insertions(+), 7 deletions(-)
>>
>> The prefix should be "orinoco_usb:", I'll fix that.
>
> Thanks for both! Will you take the patches in?
You mean patches 15 and 16? I didn't even look rest of the patches.
But not sure yet because Dave doesn't seem to like the interface and I
want to follow the discussion first.
--
Kalle Valo
prev parent reply other threads:[~2017-04-05 10:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:56 [PATCH 00/16] Networking drivers refcount conversions Elena Reshetova
2017-03-28 8:56 ` [PATCH 01/16] drivers, net, ethernet: convert clip_entry.refcnt from atomic_t to refcount_t Elena Reshetova
2017-03-28 8:56 ` [PATCH 02/16] drivers, net, ethernet: convert mtk_eth.dma_refcnt " Elena Reshetova
2017-03-28 8:56 ` [PATCH 03/16] drivers, net, mlx4: convert mlx4_cq.refcount " Elena Reshetova
2017-03-28 8:56 ` [PATCH 04/16] drivers, net, mlx4: convert mlx4_qp.refcount " Elena Reshetova
2017-03-28 8:56 ` [PATCH 05/16] drivers, net, mlx4: convert mlx4_srq.refcount " Elena Reshetova
2017-03-28 8:56 ` [PATCH 06/16] drivers, net, mlx5: convert mlx5_cq.refcount " Elena Reshetova
2017-03-28 9:33 ` David Laight
2017-03-28 14:00 ` Reshetova, Elena
2017-03-28 8:56 ` [PATCH 07/16] drivers, net, mlx5: convert fs_node.refcount " Elena Reshetova
2017-03-28 8:56 ` [PATCH 08/16] drivers, net, hamradio: convert sixpack.refcnt " Elena Reshetova
2017-03-28 8:56 ` [PATCH 09/16] drivers, net: convert masces_rx_sa.refcnt " Elena Reshetova
2017-03-28 8:56 ` [PATCH 10/16] drivers, net: convert masces_rx_sc.refcnt " Elena Reshetova
2017-03-28 8:56 ` [PATCH 11/16] drivers, net: convert masces_tx_sa.refcnt " Elena Reshetova
2017-03-28 8:56 ` [PATCH 12/16] drivers, net, ppp: convert asyncppp.refcnt " Elena Reshetova
2017-03-28 8:56 ` [PATCH 13/16] drivers, net, ppp: convert ppp_file.refcnt " Elena Reshetova
2017-03-28 8:56 ` [PATCH 14/16] drivers, net, ppp: convert syncppp.refcnt " Elena Reshetova
2017-03-28 8:56 ` [PATCH 15/16] drivers, net, intersil: convert hostap_cmd_queue.usecnt " Elena Reshetova
2017-04-03 11:38 ` Kalle Valo
2017-05-22 15:24 ` [15/16] hostap: " Kalle Valo
2017-03-28 8:56 ` [PATCH 16/16] drivers, net, intersil: convert request_context.refcount " Elena Reshetova
2017-04-03 11:41 ` Kalle Valo
2017-04-04 10:07 ` Reshetova, Elena
2017-04-05 10:33 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k26zi1p3.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ajk@comnets.uni-bremen.de \
--cc=blogic@openwrt.org \
--cc=dwindsor@gmail.com \
--cc=elena.reshetova@intel.com \
--cc=ganeshgr@chelsio.com \
--cc=gregkh@linuxfoundation.org \
--cc=ishkamiel@gmail.com \
--cc=j@w1.fi \
--cc=keescook@chromium.org \
--cc=leonro@mellanox.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=saeedm@mellanox.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox