From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: Peter.Chen@nxp.com, gregkh@linuxfoundation.org,
garsilva@embeddedor.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible
Date: Thu, 16 Feb 2017 10:54:33 +0200 [thread overview]
Message-ID: <87k28qo6ra.fsf@linux.intel.com> (raw)
In-Reply-To: <d4cfd50d-5035-aa18-5a89-2775176765b2@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
Hi,
Roger Quadros <rogerq@ti.com> writes:
> On 15/02/17 13:44, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Roger Quadros <rogerq@ti.com> writes:
>>> To avoid checkpatch warnings with new patches let's
>>> start using the BIT() macro wherever possible.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>>> drivers/usb/dwc3/core.h | 192 +++++++++++++++++++++----------------------
>>> drivers/usb/dwc3/dwc3-omap.c | 48 +++++------
>>> drivers/usb/dwc3/gadget.h | 20 ++---
>>> 3 files changed, 130 insertions(+), 130 deletions(-)
>>>
>>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>>> index 14b7602..d514dca 100644
>>> --- a/drivers/usb/dwc3/core.h
>>> +++ b/drivers/usb/dwc3/core.h
>>> @@ -65,7 +65,7 @@
>>> #define DWC3_DEVICE_EVENT_OVERFLOW 11
>>>
>>> #define DWC3_GEVNTCOUNT_MASK 0xfffc
>>> -#define DWC3_GEVNTCOUNT_EHB (1 << 31)
>>> +#define DWC3_GEVNTCOUNT_EHB BIT(31)
>>
>> don't you need to include <linux/bitops.h> for this?
>>
>
> I didn't get any build errors though.
indirect inclusion. Problems will show up only when headers are moved
around ;-)
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-02-16 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 11:38 [PATCH 0/3] usb: dwc3: trivial fixes Roger Quadros
2017-02-15 11:38 ` [PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() Roger Quadros
2017-03-09 7:17 ` Roger Quadros
2017-02-15 11:38 ` [PATCH 2/3] usb: dwc3: use BIT() macro where possible Roger Quadros
2017-02-15 11:44 ` Felipe Balbi
2017-02-15 15:25 ` Roger Quadros
2017-02-16 8:54 ` Felipe Balbi [this message]
2017-02-16 10:33 ` Roger Quadros
2017-02-16 11:08 ` [PATCH v2 " Roger Quadros
2017-03-10 11:31 ` Felipe Balbi
2017-02-15 11:38 ` [PATCH 3/3] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k28qo6ra.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=Peter.Chen@nxp.com \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox