public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode
Date: Tue, 29 Nov 2016 13:51:33 +0200	[thread overview]
Message-ID: <87k2bmo662.fsf@linux.intel.com> (raw)
In-Reply-To: <1480416997-19757-2-git-send-email-rogerq@ti.com>

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]


Hi,

Roger Quadros <rogerq@ti.com> writes:
> DCFG.DEVSPD == 0x3 is not valid and we need to set
> DCFG.DEVSPD to 0x1 for full speed mode.

seems like it has been made invalid somewhere between 1.73a and
2.60a. Can you figure it out from Documentation why and when it was made
invalid? We might need revision checks here.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2016-11-29 11:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 10:56 [PATCH 0/2] usb: dwc3: fix full speed gadget mode configuration Roger Quadros
2016-11-29 10:56 ` [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode Roger Quadros
2016-11-29 11:51   ` Felipe Balbi [this message]
2016-11-29 12:28     ` Roger Quadros
2016-12-07 12:16       ` Roger Quadros
2016-12-07 12:43         ` Felipe Balbi
2016-12-08  3:06           ` John Youn
2016-12-17  1:02             ` John Youn
2016-12-20 12:23               ` Felipe Balbi
2016-11-29 10:56 ` [PATCH 2/2] usb: dwc3: gadget: Clean up DCFG/DSTS FULLSPEED macro Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2bmo662.fsf@linux.intel.com \
    --to=balbi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox