From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbcCVFPe (ORCPT ); Tue, 22 Mar 2016 01:15:34 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:46207 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbcCVFPd convert rfc822-to-8bit (ORCPT ); Tue, 22 Mar 2016 01:15:33 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: aneesh.kumar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org From: "Aneesh Kumar K.V" To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-snps-arc@lists.infradead.org, Vineet Gupta Subject: Re: Build error due to commit 458aa76d132dc ("mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range") In-Reply-To: <20160321200035.GA31544@roeck-us.net> References: <20160321200035.GA31544@roeck-us.net> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 22 Mar 2016 10:44:45 +0530 Message-ID: <87k2kvt7p6.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16032205-0021-0000-0000-00001AD11C1F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guenter Roeck writes: > [ text/plain ] > Hi, > > Your commit 458aa76d132dc1 ("mm/thp/migration: switch from flush_tlb_range > to flush_pmd_tlb_range") causes a build error when building > arcv2:vdk_hs38_smp_defconfig. > > include/asm-generic/pgtable.h:799:45: note: in expansion of macro ‘BUILD_BUG’ > #define flush_pmd_tlb_range(vma, addr, end) BUILD_BUG() > ^ > ./arch/arc/include/asm/tlbflush.h:37:13: note: > in expansion of macro ‘flush_pmd_tlb_range’ > > The build triggers the newly introduced BUILD_BUG(). > > When building the image without the BUILD_BUG(), ie with no definition > of flush_pmd_tlb_range(), the problem is gone. This suggests that the > function is not needed for this build. > > I could submit a patch to remove the BUILD_BUG(), but maybe you had a reason > for introducing it. Can you elaborate why you introduced the BUILD_BUG() ? > Isn't this going to be fixed by an update to ARC tree ? http://article.gmane.org/gmane.linux.kernel.mm/148412 I also don't understand why we would hit that BUILD_BUG, if we are not calling flush_pmd_tlb_range(). -aneesh