* [PATCH] virtio_console: init work unconditionally
@ 2015-02-28 17:41 Michael S. Tsirkin
2015-03-02 5:56 ` Amit Shah
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2015-02-28 17:41 UTC (permalink / raw)
To: linux-kernel, Rusty Russell
Cc: Amit Shah, Arnd Bergmann, Greg Kroah-Hartman, virtualization
when multiport is off, we don't initialize config work,
but we then cancel uninitialized control_work on freeze.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/char/virtio_console.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index fae2dbb..def736d 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -2040,12 +2040,13 @@ static int virtcons_probe(struct virtio_device *vdev)
virtio_device_ready(portdev->vdev);
+ INIT_WORK(&portdev->control_work, &control_work_handler);
+
if (multiport) {
unsigned int nr_added_bufs;
spin_lock_init(&portdev->c_ivq_lock);
spin_lock_init(&portdev->c_ovq_lock);
- INIT_WORK(&portdev->control_work, &control_work_handler);
nr_added_bufs = fill_queue(portdev->c_ivq,
&portdev->c_ivq_lock);
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] virtio_console: init work unconditionally
2015-02-28 17:41 [PATCH] virtio_console: init work unconditionally Michael S. Tsirkin
@ 2015-03-02 5:56 ` Amit Shah
2015-03-04 0:33 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Amit Shah @ 2015-03-02 5:56 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Rusty Russell, Arnd Bergmann, Greg Kroah-Hartman,
virtualization
On (Sat) 28 Feb 2015 [18:41:34], Michael S. Tsirkin wrote:
> when multiport is off, we don't initialize config work,
> but we then cancel uninitialized control_work on freeze.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio_console: init work unconditionally
2015-03-02 5:56 ` Amit Shah
@ 2015-03-04 0:33 ` Rusty Russell
0 siblings, 0 replies; 3+ messages in thread
From: Rusty Russell @ 2015-03-04 0:33 UTC (permalink / raw)
To: Amit Shah, Michael S. Tsirkin
Cc: linux-kernel, Arnd Bergmann, Greg Kroah-Hartman, virtualization
Amit Shah <amit.shah@redhat.com> writes:
> On (Sat) 28 Feb 2015 [18:41:34], Michael S. Tsirkin wrote:
>> when multiport is off, we don't initialize config work,
>> but we then cancel uninitialized control_work on freeze.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
Thanks, applied.
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-04 0:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-28 17:41 [PATCH] virtio_console: init work unconditionally Michael S. Tsirkin
2015-03-02 5:56 ` Amit Shah
2015-03-04 0:33 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox