From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Arun Sharma <asharma@fb.com>,
Rodrigo Campos <rodrigo@sdfg.com.ar>,
Andi Kleen <andi@firstfloor.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v7)
Date: Mon, 27 Jan 2014 15:22:43 +0900 [thread overview]
Message-ID: <87k3dm54gc.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140123162248.GF1180@krava.brq.redhat.com> (Jiri Olsa's message of "Thu, 23 Jan 2014 17:22:48 +0100")
On Thu, 23 Jan 2014 17:22:48 +0100, Jiri Olsa wrote:
> On Thu, Jan 23, 2014 at 09:13:44AM +0900, Namhyung Kim wrote:
>>
>> $ perf report --no-call-graph --children --stdio
>>
>> # Self Children Command Shared Object Symbol
>> # ........ ........ ....... ................. .....................
>> #
>> 0.00% 91.50% abc libc-2.17.so [.] __libc_start_main
>> 0.00% 91.50% abc abc [.] main
>> 0.00% 91.50% abc abc [.] c
>> 0.00% 91.50% abc abc [.] b
>> 91.50% 91.50% abc abc [.] a
>> 0.00% 8.18% abc ld-2.17.so [.] _dl_sysdep_start
>> 8.18% 8.18% abc ld-2.17.so [.] strlen
>> 0.01% 0.33% abc ld-2.17.so [.] _start
>> 0.31% 0.31% abc [kernel.kallsyms] [k] page_fault
>
> I couldnt get this one working:
>
> [jolsa@krava perf]$ ./perf report --no-call-graph --children --stdio
>
> #
> # Self Children Command Shared Object Symbol
> # ........ ........ ....... ............. ..........................
> #
> 94.47% 94.47% abc abc [.] a
> 4.74% 4.74% abc ld-2.17.so [.] _dl_map_object_from_fd
> 0.75% 0.75% abc ld-2.17.so [.] _dl_start
> 0.04% 0.04% abc ld-2.17.so [.] _start
>
> I was looking for cumulated stdio output without callchain unwinded,
> TUI shows it properly as default
Oops, I missed a change below, sorry.
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index ac658135079f..c1d4ccd755ed 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -538,7 +538,8 @@ int sample__resolve_callchain(struct perf_sample *sample, struct symbol **parent
if (sample->callchain == NULL)
return 0;
- if (symbol_conf.use_callchain || sort__has_parent) {
+ if (symbol_conf.use_callchain || symbol_conf.cumulate_callchain ||
+ sort__has_parent) {
return machine__resolve_callchain(al->machine, evsel, al->thread,
sample, parent, al, max_stack);
}
--
1.7.11.7
prev parent reply other threads:[~2014-01-27 6:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 0:13 [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v7) Namhyung Kim
2014-01-23 0:13 ` [PATCH 01/21] perf tools: Introduce struct hist_entry_iter Namhyung Kim
2014-01-23 14:44 ` Jiri Olsa
2014-01-27 5:41 ` Namhyung Kim
2014-01-27 8:49 ` Jiri Olsa
2014-01-23 14:56 ` Jiri Olsa
2014-01-27 5:45 ` Namhyung Kim
2014-01-23 0:13 ` [PATCH 02/21] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-01-23 0:13 ` [PATCH 03/21] perf hists: Check if accumulated when adding a " Namhyung Kim
2014-01-23 0:13 ` [PATCH 04/21] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-01-23 0:13 ` [PATCH 05/21] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-01-23 0:13 ` [PATCH 06/21] perf report: Cache cumulative callchains Namhyung Kim
2014-01-23 0:13 ` [PATCH 07/21] perf callchain: Add callchain_cursor_snapshot() Namhyung Kim
2014-01-23 0:13 ` [PATCH 08/21] perf tools: Save callchain info for each cumulative entry Namhyung Kim
2014-01-23 0:13 ` [PATCH 09/21] perf hists: Sort hist entries by accumulated period Namhyung Kim
2014-01-23 0:13 ` [PATCH 10/21] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-01-23 0:13 ` [PATCH 11/21] perf ui/browser: " Namhyung Kim
2014-01-23 0:13 ` [PATCH 12/21] perf ui/gtk: " Namhyung Kim
2014-01-23 0:13 ` [PATCH 13/21] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-01-23 0:13 ` [PATCH 14/21] perf tools: Add more hpp helper functions Namhyung Kim
2014-01-23 0:13 ` [PATCH 15/21] perf report: Add --children option Namhyung Kim
2014-01-23 0:14 ` [PATCH 16/21] perf report: Add report.children config option Namhyung Kim
2014-01-23 0:14 ` [PATCH 17/21] perf tools: Add callback function to hist_entry_iter Namhyung Kim
2014-01-23 0:14 ` [PATCH 18/21] perf top: Convert " Namhyung Kim
2014-01-23 0:14 ` [PATCH 19/21] perf top: Add --children option Namhyung Kim
2014-01-23 0:14 ` [PATCH 20/21] perf top: Add top.children config option Namhyung Kim
2014-01-23 0:14 ` [PATCH 21/21] perf tools: Enable --children option by default Namhyung Kim
2014-01-23 16:22 ` [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v7) Jiri Olsa
2014-01-27 6:22 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3dm54gc.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=asharma@fb.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox