* [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.
@ 2013-05-03 9:17 dl9pf
2013-05-03 9:23 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: dl9pf @ 2013-05-03 9:17 UTC (permalink / raw)
To: dl9pf; +Cc: pageexec, daniel.vetter, airlied, intel-gfx, dri-devel,
linux-kernel
From: Jan-Simon Möller <dl9pf@gmx.de>
Description:
intel_gmbus_is_forced_bit is no extern as its body is right below.
Likewise for intel_gmbus_is_port_valid.
This fixes a compilation issue with clang. An initial version of this patch
was developed by PaX Team <pageexec at freemail.hu>.
This is respin of this patch.
Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
CC: pageexec@freemail.hu
CC: daniel.vetter@ffwll.ch
CC: airlied@linux.ie
CC: intel-gfx@lists.freedesktop.org
CC: dri-devel@lists.freedesktop.org
CC: linux-kernel@vger.kernel.org
---
drivers/gpu/drm/i915/i915_drv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 3ac71db..3c9ebc1 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1806,7 +1806,7 @@ void i915_teardown_sysfs(struct drm_device *dev_priv);
/* intel_i2c.c */
extern int intel_setup_gmbus(struct drm_device *dev);
extern void intel_teardown_gmbus(struct drm_device *dev);
-extern inline bool intel_gmbus_is_port_valid(unsigned port)
+static bool intel_gmbus_is_port_valid(unsigned port)
{
return (port >= GMBUS_PORT_SSC && port <= GMBUS_PORT_DPD);
}
@@ -1815,7 +1815,7 @@ extern struct i2c_adapter *intel_gmbus_get_adapter(
struct drm_i915_private *dev_priv, unsigned port);
extern void intel_gmbus_set_speed(struct i2c_adapter *adapter, int speed);
extern void intel_gmbus_force_bit(struct i2c_adapter *adapter, bool force_bit);
-extern inline bool intel_gmbus_is_forced_bit(struct i2c_adapter *adapter)
+static bool intel_gmbus_is_forced_bit(struct i2c_adapter *adapter)
{
return container_of(adapter, struct intel_gmbus, adapter)->force_bit;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.
2013-05-03 9:17 [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver dl9pf
@ 2013-05-03 9:23 ` Daniel Vetter
2013-05-03 12:03 ` [Intel-gfx] " Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2013-05-03 9:23 UTC (permalink / raw)
To: dl9pf; +Cc: pageexec, daniel.vetter, airlied, intel-gfx, dri-devel,
linux-kernel
On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf@gmx.de wrote:
> From: Jan-Simon Möller <dl9pf@gmx.de>
>
> Description:
> intel_gmbus_is_forced_bit is no extern as its body is right below.
> Likewise for intel_gmbus_is_port_valid.
>
> This fixes a compilation issue with clang. An initial version of this patch
> was developed by PaX Team <pageexec at freemail.hu>.
> This is respin of this patch.
>
> Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
> CC: pageexec@freemail.hu
> CC: daniel.vetter@ffwll.ch
> CC: airlied@linux.ie
> CC: intel-gfx@lists.freedesktop.org
> CC: dri-devel@lists.freedesktop.org
> CC: linux-kernel@vger.kernel.org
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.
2013-05-03 9:23 ` Daniel Vetter
@ 2013-05-03 12:03 ` Jani Nikula
2013-05-03 16:16 ` Daniel Vetter
2013-05-04 8:55 ` PaX Team
0 siblings, 2 replies; 6+ messages in thread
From: Jani Nikula @ 2013-05-03 12:03 UTC (permalink / raw)
To: Daniel Vetter, dl9pf
Cc: airlied, daniel.vetter, intel-gfx, linux-kernel, dri-devel,
pageexec
On Fri, 03 May 2013, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf@gmx.de wrote:
>> From: Jan-Simon Möller <dl9pf@gmx.de>
>>
>> Description:
>> intel_gmbus_is_forced_bit is no extern as its body is right below.
>> Likewise for intel_gmbus_is_port_valid.
>>
>> This fixes a compilation issue with clang. An initial version of this patch
>> was developed by PaX Team <pageexec at freemail.hu>.
>> This is respin of this patch.
>>
>> Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
>> CC: pageexec@freemail.hu
>> CC: daniel.vetter@ffwll.ch
>> CC: airlied@linux.ie
>> CC: intel-gfx@lists.freedesktop.org
>> CC: dri-devel@lists.freedesktop.org
>> CC: linux-kernel@vger.kernel.org
> Picked up for -fixes, thanks for the patch.
Please drop it.
The patch removes the inline keyword, creating dozens of copies of the
functions, and consequently loads of warnings:
drivers/gpu/drm/i915/i915_drv.h:1803:13: warning: ‘intel_gmbus_is_port_valid’ defined but not used [-Wunused-function]
drivers/gpu/drm/i915/i915_drv.h:1812:13: warning: ‘intel_gmbus_is_forced_bit’ defined but not used [-Wunused-function]
BR,
Jani.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.
2013-05-03 12:03 ` [Intel-gfx] " Jani Nikula
@ 2013-05-03 16:16 ` Daniel Vetter
2013-05-04 8:55 ` PaX Team
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2013-05-03 16:16 UTC (permalink / raw)
To: Jani Nikula
Cc: Daniel Vetter, dl9pf, airlied, daniel.vetter, intel-gfx,
linux-kernel, dri-devel, pageexec
On Fri, May 03, 2013 at 03:03:37PM +0300, Jani Nikula wrote:
> On Fri, 03 May 2013, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf@gmx.de wrote:
> >> From: Jan-Simon Möller <dl9pf@gmx.de>
> >>
> >> Description:
> >> intel_gmbus_is_forced_bit is no extern as its body is right below.
> >> Likewise for intel_gmbus_is_port_valid.
> >>
> >> This fixes a compilation issue with clang. An initial version of this patch
> >> was developed by PaX Team <pageexec at freemail.hu>.
> >> This is respin of this patch.
> >>
> >> Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
> >> CC: pageexec@freemail.hu
> >> CC: daniel.vetter@ffwll.ch
> >> CC: airlied@linux.ie
> >> CC: intel-gfx@lists.freedesktop.org
> >> CC: dri-devel@lists.freedesktop.org
> >> CC: linux-kernel@vger.kernel.org
> > Picked up for -fixes, thanks for the patch.
>
> Please drop it.
>
> The patch removes the inline keyword, creating dozens of copies of the
> functions, and consequently loads of warnings:
>
> drivers/gpu/drm/i915/i915_drv.h:1803:13: warning: ‘intel_gmbus_is_port_valid’ defined but not used [-Wunused-function]
> drivers/gpu/drm/i915/i915_drv.h:1812:13: warning: ‘intel_gmbus_is_forced_bit’ defined but not used [-Wunused-function]
Meh, rather embarrassing patch reading fail here. Dropped.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.
2013-05-03 12:03 ` [Intel-gfx] " Jani Nikula
2013-05-03 16:16 ` Daniel Vetter
@ 2013-05-04 8:55 ` PaX Team
2013-05-06 12:46 ` Jan-Simon Möller
1 sibling, 1 reply; 6+ messages in thread
From: PaX Team @ 2013-05-04 8:55 UTC (permalink / raw)
To: Daniel Vetter, dl9pf, Jani Nikula
Cc: airlied, daniel.vetter, intel-gfx, linux-kernel, dri-devel
On 3 May 2013 at 15:03, Jani Nikula wrote:
> >> This fixes a compilation issue with clang. An initial version of this patch
> >> was developed by PaX Team <pageexec at freemail.hu>.
> >> This is respin of this patch.
> >>
> >> Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
> >> CC: pageexec@freemail.hu
> >> CC: daniel.vetter@ffwll.ch
> >> CC: airlied@linux.ie
> >> CC: intel-gfx@lists.freedesktop.org
> >> CC: dri-devel@lists.freedesktop.org
> >> CC: linux-kernel@vger.kernel.org
> > Picked up for -fixes, thanks for the patch.
>
> Please drop it.
>
> The patch removes the inline keyword, creating dozens of copies of the
> functions, and consequently loads of warnings:
in my original patch they were both static inline, not sure where the
inline got lost...
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.
2013-05-04 8:55 ` PaX Team
@ 2013-05-06 12:46 ` Jan-Simon Möller
0 siblings, 0 replies; 6+ messages in thread
From: Jan-Simon Möller @ 2013-05-06 12:46 UTC (permalink / raw)
To: pageexec
Cc: Daniel Vetter, Jani Nikula, airlied, daniel.vetter, intel-gfx,
linux-kernel, dri-devel
Ok, so let me resend a version with "static inline" .
Best,
JS
On Saturday 04 May 2013 10:55:50 PaX Team wrote:
> On 3 May 2013 at 15:03, Jani Nikula wrote:
> > >> This fixes a compilation issue with clang. An initial version of this
> > >> patch
> > >> was developed by PaX Team <pageexec at freemail.hu>.
> > >> This is respin of this patch.
> > >>
> > >> Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
> > >> CC: pageexec@freemail.hu
> > >> CC: daniel.vetter@ffwll.ch
> > >> CC: airlied@linux.ie
> > >> CC: intel-gfx@lists.freedesktop.org
> > >> CC: dri-devel@lists.freedesktop.org
> > >> CC: linux-kernel@vger.kernel.org
> > >
> > > Picked up for -fixes, thanks for the patch.
> >
> > Please drop it.
> >
> > The patch removes the inline keyword, creating dozens of copies of the
>
> > functions, and consequently loads of warnings:
> in my original patch they were both static inline, not sure where the
> inline got lost...
--
Dipl.-Ing.
Jan-Simon Möller
jansimon.moeller@gmx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-06 12:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-03 9:17 [PATCH] [TRIVIAL] Fix declaration of intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver dl9pf
2013-05-03 9:23 ` Daniel Vetter
2013-05-03 12:03 ` [Intel-gfx] " Jani Nikula
2013-05-03 16:16 ` Daniel Vetter
2013-05-04 8:55 ` PaX Team
2013-05-06 12:46 ` Jan-Simon Möller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox