* [PATCH 0/4 V2] Use get_online_cpus to avoid races involving CPU hotplug
@ 2012-08-03 19:32 Silas Boyd-Wickizer
2012-08-29 20:32 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Silas Boyd-Wickizer @ 2012-08-03 19:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul E. McKenney
Hello,
This is the second version of the patches to fix races described in:
https://groups.google.com/forum/?fromgroups#!topic/linux.kernel/iSUDr94Qehc
The changes in this version are:
* fix commit log typo;
* prevent a race in via_cputemp_exit;
* and a new patch that prevents races during init/exit in
drivers/hwmon/coretemp.c.
Silas
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 0/4 V2] Use get_online_cpus to avoid races involving CPU hotplug
2012-08-03 19:32 [PATCH 0/4 V2] Use get_online_cpus to avoid races involving CPU hotplug Silas Boyd-Wickizer
@ 2012-08-29 20:32 ` Rusty Russell
2012-09-04 16:36 ` Silas Boyd-Wickizer
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2012-08-29 20:32 UTC (permalink / raw)
To: Silas Boyd-Wickizer, linux-kernel; +Cc: Paul E. McKenney
Silas Boyd-Wickizer <sbw@mit.edu> writes:
> Hello,
>
> This is the second version of the patches to fix races described in:
>
> https://groups.google.com/forum/?fromgroups#!topic/linux.kernel/iSUDr94Qehc
>
> The changes in this version are:
>
> * fix commit log typo;
> * prevent a race in via_cputemp_exit;
> * and a new patch that prevents races during init/exit in
> drivers/hwmon/coretemp.c.
Hi Silas,
Good work! How did you find these?
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 0/4 V2] Use get_online_cpus to avoid races involving CPU hotplug
2012-08-29 20:32 ` Rusty Russell
@ 2012-09-04 16:36 ` Silas Boyd-Wickizer
0 siblings, 0 replies; 3+ messages in thread
From: Silas Boyd-Wickizer @ 2012-09-04 16:36 UTC (permalink / raw)
To: Rusty Russell; +Cc: linux-kernel, Paul E. McKenney
Hi Rusty,
I used libsparse and kernel source annotations to check that code uses
for_each_online_cpu in contexts with hotplug disabled
(e.g. get_online_cpus(), preempt_disable, ..). I compiled with an x86
64-bit allyesconfig, so I missed other architecture specific usages.
The checker code isn't great and the results still require some manual
inspection for weeding out false positives, etc:
http://pdos.csail.mit.edu/~sbw/online-checker/
Silas
On Thu, Aug 30, 2012 at 06:02:11AM +0930, Rusty Russell wrote:
> Silas Boyd-Wickizer <sbw@mit.edu> writes:
>
> > Hello,
> >
> > This is the second version of the patches to fix races described in:
> >
> > https://groups.google.com/forum/?fromgroups#!topic/linux.kernel/iSUDr94Qehc
> >
> > The changes in this version are:
> >
> > * fix commit log typo;
> > * prevent a race in via_cputemp_exit;
> > * and a new patch that prevents races during init/exit in
> > drivers/hwmon/coretemp.c.
>
> Hi Silas,
>
> Good work! How did you find these?
>
> Cheers,
> Rusty.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-04 16:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-03 19:32 [PATCH 0/4 V2] Use get_online_cpus to avoid races involving CPU hotplug Silas Boyd-Wickizer
2012-08-29 20:32 ` Rusty Russell
2012-09-04 16:36 ` Silas Boyd-Wickizer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox