[PATCH] modpost: use proper kernel style for autogenerated files

[PATCH] modpost: use proper kernel style for autogenerated files

[Greg Kroah-Hartman]

If the kernel build process is creating files automatically, the least
it can do is create them in a properly formatted manner.  Sure, it's a
minor issue, but being consistent is nice.

Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Alessio Igor Bogani <abogani@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index c4e7d15..05748b3 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1850,14 +1850,14 @@ static void add_header(struct buffer *b, struct module *mod)
 	buf_printf(b, "\n");
 	buf_printf(b, "struct module __this_module\n");
 	buf_printf(b, "__attribute__((section(\".gnu.linkonce.this_module\"))) = {\n");
-	buf_printf(b, " .name = KBUILD_MODNAME,\n");
+	buf_printf(b, "\t.name = KBUILD_MODNAME,\n");
 	if (mod->has_init)
-		buf_printf(b, " .init = init_module,\n");
+		buf_printf(b, "\t.init = init_module,\n");
 	if (mod->has_cleanup)
 		buf_printf(b, "#ifdef CONFIG_MODULE_UNLOAD\n"
-			      " .exit = cleanup_module,\n"
+			      "\t.exit = cleanup_module,\n"
 			      "#endif\n");
-	buf_printf(b, " .arch = MODULE_ARCH_INIT,\n");
+	buf_printf(b, "\t.arch = MODULE_ARCH_INIT,\n");
 	buf_printf(b, "};\n");
 }
 

Re: [PATCH] modpost: use proper kernel style for autogenerated files

[Rusty Russell]

On Wed, 25 Apr 2012 11:10:15 -0700, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> If the kernel build process is creating files automatically, the least
> it can do is create them in a properly formatted manner.  Sure, it's a
> minor issue, but being consistent is nice.
> 
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Alessio Igor Bogani <abogani@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Ben Hutchings <ben@decadent.org.uk>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Applied, thanks (I think!)

Cheers,
Rusty.