From: Andi Kleen <andi@firstfloor.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Stefani Seibold <stefani@seibold.net>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org
Subject: Re: [PATCH] proc: revert to show stack information in /proc/{pid}/status
Date: Sat, 02 Jan 2010 02:42:48 +0100 [thread overview]
Message-ID: <87k4w1704n.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20100101220529.GL4620@const> (Samuel Thibault's message of "Fri, 1 Jan 2010 23:05:29 +0100")
Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
> Stefani Seibold, le Fri 01 Jan 2010 16:10:16 +0100, a écrit :
>> But ps is not a performance critical application nor a cat
>> /proc/*/status!
>
> Errr, maybe not so much as some other operations, but a lot of tools use
> them, so it's really worth considering it.
As an historical anecdote one of my first patches to Linux ever made
exactly the same mistake as Stefani's (adding mmap_sem to a proc file
read by proc). It was quickly reverted again by Linus when the
reports of ps not working under swapping poured in.
Same should be done with this patch (commit 9ebd4eba761b624a6a6c9189335adeddcb1fa0e0)
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-01-02 1:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 14:12 [PATCH] proc: revert to show stack information in /proc/{pid}/status KOSAKI Motohiro
2009-12-31 15:48 ` Stefani Seibold
2010-01-01 14:14 ` KOSAKI Motohiro
2010-01-01 15:10 ` Stefani Seibold
2010-01-01 22:05 ` Samuel Thibault
2010-01-01 22:21 ` Stefani Seibold
2010-01-02 5:53 ` KOSAKI Motohiro
2010-01-02 8:26 ` Stefani Seibold
2010-01-02 14:05 ` [PATCH] partial revert to show stack information in /proc/<pid>/status Stefani Seibold
2010-01-05 5:24 ` KOSAKI Motohiro
2010-01-02 1:42 ` Andi Kleen [this message]
2010-01-01 15:49 ` [PATCH] proc: revert to show stack information in /proc/{pid}/status Andi Kleen
2010-01-01 16:09 ` Stefani Seibold
2010-01-07 21:52 ` Andrew Morton
2010-01-08 0:21 ` KOSAKI Motohiro
2010-01-08 0:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4w1704n.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefani@seibold.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox