Re: GFS2: Add LED support to GFS2

Steven Whitehouse
2009-07-22T15:04:30Z

Hi,

On Wed, 2009-07-22 at 16:55 +0200, Andi Kleen wrote:
> > It would be difficult to make that generic since the errors and the
> > resulting actions which can be taken vary from fs to fs. The main reason
> > that I didn't do it at this point in time is that the GFS2 error
> > handling needs revising anyway, and once that is done (probably with an
> > errors= option similar to ext2/3/4) it might be possible to think about
> > LED support for that,
>
> I was thinking to have a couple of generic functions like:
>
> log_activity()
> error_happened()
>
> ...
>
> that everyone could call.
>
> -Andi
>
>
Indeed, but we'd need to allow for different classes of activity or
errors, and then filtering them per-LED. With my proposed patch that is
avoided due to having a small number of triggers on the different
events, so selecting the trigger acts as a filter on the event type.

So I guess what I'm really getting at, is what would the user interface
be for this scheme to set up the LEDs?

I did consider adding a feature to filter events on a per superblock
basis, but I decided against it in the end, as it seemed to be making
things too complicated (how should we specify the superblock? what
should the user interface be?).

Maybe there is an easy way to do that which I've not spotted...

Steve.