public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: apgarcia@uwm.edu (A. P. Garcia)
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: 2.4.0-pre compile err (pcxx)
Date: 01 Jan 2001 22:41:49 +0000	[thread overview]
Message-ID: <87k88e3nf6.fsf@uwm.edu> (raw)
In-Reply-To: <E14D9My-00017N-00@the-village.bc.nu>
In-Reply-To: Alan Cox's message of "Mon, 1 Jan 2001 18:07:38 +0000 (GMT)"

this is a patch against the pcxx.c in the prerelease distribution
[clear thinkos.  brain ok now.]

anyhow, before it was awful close ;-)

thanks again


--- pcxx.c~	Fri Dec 29 22:35:47 2000
+++ pcxx.c	Mon Jan  1 22:30:00 2001
@@ -152,7 +152,7 @@
 DECLARE_TASK_QUEUE(tq_pcxx);
 
 static void pcxxpoll(unsigned long dummy);
-static void pcxxdelay(int);
+static void pcxxdelay(unsigned long);
 static void fepcmd(struct channel *, int, int, int, int, int);
 static void pcxe_put_char(struct tty_struct *, unsigned char);
 static void pcxe_flush_chars(struct tty_struct *);
@@ -1821,9 +1821,9 @@
 /*
  * pcxxdelay - delays a specified number of milliseconds
  */
-static void pcxxdelay(int msec)
+static void pcxxdelay(unsigned long ms)
 {
-	mdelay(mseconds);
+	mdelay(ms);
 }




Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

> > when i make bzimage with the pc/xx driver configured as a module, it
> > compiles ok.  configuring it as built-in gives the following error:
> 
> Im amazed it built as a module - thats why I missed the error
> 
> > pcxx.c:1826: `mseconds' undeclared (first use in this function)
> > pcxx.c:1826: (Each undeclared identifier is reported only once
> 
> 
> --- drivers/char/pcxx.c~	Sat Dec 30 01:07:21 2000
> +++ drivers/char/pcxx.c	Mon Jan  1 17:12:05 2001
> @@ -1823,7 +1823,7 @@
>   */
>  static void pcxxdelay(int msec)
>  {
> -	mdelay(mseconds);
> +	mdelay(msec);
>  }
>  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

      parent reply	other threads:[~2001-01-01 23:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-01 17:43 2.4.0-pre compile err (pcxx) A. P. Garcia
2001-01-01 18:07 ` Alan Cox
2001-01-01 19:49   ` A. P. Garcia
2001-01-01 22:41   ` A. P. Garcia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k88e3nf6.fsf@uwm.edu \
    --to=apgarcia@uwm.edu \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox