2.4.0-pre compile err (pcxx)

2.4.0-pre compile err (pcxx)

[A. P. Garcia]

when i make bzimage with the pc/xx driver configured as a module, it
compiles ok.  configuring it as built-in gives the following error:

gcc -D__KERNEL__ -I/usr/src/linux-2.4.0-prerelease/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=i586    -c -o pcxx.o pcxx.c
pcxx.c: In function `pcxxdelay':
pcxx.c:1826: `mseconds' undeclared (first use in this function)
pcxx.c:1826: (Each undeclared identifier is reported only once
pcxx.c:1826: for each function it appears in.)
make[3]: *** [pcxx.o] Error 1
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: 2.4.0-pre compile err (pcxx)

[Alan Cox]

> when i make bzimage with the pc/xx driver configured as a module, it
> compiles ok.  configuring it as built-in gives the following error:

Im amazed it built as a module - thats why I missed the error

> pcxx.c:1826: `mseconds' undeclared (first use in this function)
> pcxx.c:1826: (Each undeclared identifier is reported only once


--- drivers/char/pcxx.c~	Sat Dec 30 01:07:21 2000
+++ drivers/char/pcxx.c	Mon Jan  1 17:12:05 2001
@@ -1823,7 +1823,7 @@
  */
 static void pcxxdelay(int msec)
 {
-	mdelay(mseconds);
+	mdelay(msec);
 }
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: 2.4.0-pre compile err (pcxx)

[A. P. Garcia]

Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

> > when i make bzimage with the pc/xx driver configured as a module, it
> > compiles ok.  configuring it as built-in gives the following error:
> 
> Im amazed it built as a module - thats why I missed the error

well, the kernel compiled, but i kind of forgot to make modules

:-)
many thanks
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: 2.4.0-pre compile err (pcxx)

[A. P. Garcia]

this is a patch against the pcxx.c in the prerelease distribution
[clear thinkos.  brain ok now.]

anyhow, before it was awful close ;-)

thanks again


--- pcxx.c~	Fri Dec 29 22:35:47 2000
+++ pcxx.c	Mon Jan  1 22:30:00 2001
@@ -152,7 +152,7 @@
 DECLARE_TASK_QUEUE(tq_pcxx);
 
 static void pcxxpoll(unsigned long dummy);
-static void pcxxdelay(int);
+static void pcxxdelay(unsigned long);
 static void fepcmd(struct channel *, int, int, int, int, int);
 static void pcxe_put_char(struct tty_struct *, unsigned char);
 static void pcxe_flush_chars(struct tty_struct *);
@@ -1821,9 +1821,9 @@
 /*
  * pcxxdelay - delays a specified number of milliseconds
  */
-static void pcxxdelay(int msec)
+static void pcxxdelay(unsigned long ms)
 {
-	mdelay(mseconds);
+	mdelay(ms);
 }




Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

> > when i make bzimage with the pc/xx driver configured as a module, it
> > compiles ok.  configuring it as built-in gives the following error:
> 
> Im amazed it built as a module - thats why I missed the error
> 
> > pcxx.c:1826: `mseconds' undeclared (first use in this function)
> > pcxx.c:1826: (Each undeclared identifier is reported only once
> 
> 
> --- drivers/char/pcxx.c~	Sat Dec 30 01:07:21 2000
> +++ drivers/char/pcxx.c	Mon Jan  1 17:12:05 2001
> @@ -1823,7 +1823,7 @@
>   */
>  static void pcxxdelay(int msec)
>  {
> -	mdelay(mseconds);
> +	mdelay(msec);
>  }
>  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/