From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD55C3DC4A4 for ; Tue, 25 Aug 2026 08:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787645610; cv=none; b=shQadbQGwJzui+sO1g1JIh6946isRUatEUqBwFqB+1fBVwbuCniyu1+SuW8UQVMlWtxIlJSGbFtJYJ7DVB3veRwDZXvsywoDorQCsGtvaGRfU1Uw7X1V6uTPtloj+2Mk1nYkVcpjDLF4HSxHm5yPYXPgtyQNkmV0Z63A9swQe6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787645610; c=relaxed/simple; bh=1yatvnucvowUBLiZV/e86RBt+bEgEplpvaCSySex1gA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=m1OqXdaqeR2LDp/ISSawYwNT4K18A1lvJs102mGd+jMGGNcNzxrTvlQ1gtCdDIh/gSUr+o9tLmbQNBMpZolCJ5XhS4BIIojmVjH8fz9PDnHsZqt5VoKviDVtuuPw3LKapIGpjIlNjljwvVtdEmbx+SVAVpj4CbFNfNo88C7pB9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=KFZxCAhF; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="KFZxCAhF" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id EB98D4E412E1; Tue, 25 Aug 2026 08:13:23 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id BF170604C4; Tue, 25 Aug 2026 08:13:23 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DABCD11C7A07F; Tue, 25 Aug 2026 10:13:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1787645599; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=1yatvnucvowUBLiZV/e86RBt+bEgEplpvaCSySex1gA=; b=KFZxCAhFbsazub9sZ7HcyNjILQBooj34vUGCNNiW4HHN9exzQQ4HBmHbMCXuHKpPtAM/xC 34Tgf4yK6xYaEncdvR6DqiC4wTIu+m3bIr8r+RU9IjvvlYLaObspFHD/esMAZ1tGFP86Jz kAEkehAjdIL4TZRhU0MMt6haHfm5RFKE7vkkQeRrLpxQeIk7kNp682xjyFC8ben3pDhX+W 4CQh2ZHPdR6qoaARZ/ao+BDZKnPrzZAIFT+YsCooXg9BXAReelg1XJnsw2gIUS5dqTlR+h Qc75XZrnFnO0kfKGZw1xYEVK1nIDnzPDNW3QxKeavYfAR7C3ImaXgRFwEnP60Q== From: Miquel Raynal To: Triet Hoang Cc: michal.simek@amd.com, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memory: pl353: Convert to DEFINE_SIMPLE_DEV_PM_OPS() In-Reply-To: <20260821074417.261168-1-triet.hoang.dev@gmail.com> (Triet Hoang's message of "Fri, 21 Aug 2026 14:44:17 +0700") References: <20260821074417.261168-1-triet.hoang.dev@gmail.com> User-Agent: mu4e 1.12.12; emacs 30.2 Date: Tue, 25 Aug 2026 10:13:17 +0200 Message-ID: <87ld9uk482.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Last-TLS-Session-Version: TLSv1.3 Hi Triet, On 21/08/2026 at 14:44:17 +07, Triet Hoang wrote: > Convert the deprecated SIMPLE_DEV_PM_OPS > to DEFINE_SIMPLE_DEV_PM_OPS > and pm_sleep_ptr(). > > This lets us drop the __maybe_unused annotations > from its suspend and resume callbacks, > also reduces kernel size in case CONFIG_PM or > CONFIG_PM_SLEEP is disabled. Here is the occasion for sending a v2 with your two patches: wrapping at 50 chars is abusive :) Other than that, I guess the diff is fine. Reviewed-by: Miquel Raynal