The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Linus Walleij <linusw@kernel.org>, Vicente Bergas <vicencb@gmail.com>
Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-gpio@vger.kernel.org
Subject: Re: gpio-mt7621 unroutable IRQs to bank0
Date: Tue, 05 May 2026 16:21:51 +0200	[thread overview]
Message-ID: <87lddyx7gg.ffs@tglx> (raw)
In-Reply-To: <CAD++jLn9DpaknOm3S9ZUOY6Jyo=SuhVSv-vzNaw=S1uuOeYoRg@mail.gmail.com>

On Tue, May 05 2026 at 14:01, Linus Walleij wrote:
> On Sat, May 2, 2026 at 11:52 PM Vicente Bergas <vicencb@gmail.com> wrote:
>> As a way to prove that this is indeed the problem,
>> the following workaround makes it work.
>> It just inverts the sorting order of all matches,
>> so it picks Bank0 instead of Bank2.
>
> That's a tricksy bug, I can't exactly see where the issue
> is.
>
> I think to solve this you might need to allocate an external
> irqdomain that deal with the three different gpiochip
> instances when translating the irqs.

struct gpio_chip has this:

        /**
         * @of_node_instance_match:
         *
         * Determine if a chip is the right instance. Must be implemented by
         * any driver using more than one gpio_chip per device tree node.
         * Returns true if gc is the instance indicated by i (which is the
         * first cell in the phandles for GPIO lines and gpio-ranges).
         */
        bool (*of_node_instance_match)(struct gpio_chip *gc, unsigned int i);

That driver falls in the category and lacks that callback, no?

Thanks,

        tglx

  reply	other threads:[~2026-05-05 14:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAMcf8C_A9dJ_v4QRKtb9eGNOpJ7BZNOGsFP4i2WFOZxOVBPnQ@mail.gmail.com>
2026-05-05 12:01 ` gpio-mt7621 unroutable IRQs to bank0 Linus Walleij
2026-05-05 14:21   ` Thomas Gleixner [this message]
2026-05-05 15:05     ` Sergio Paracuellos
2026-05-05 21:36       ` Vicente Bergas
2026-05-06 17:43         ` Sergio Paracuellos
2026-05-06 22:32           ` Vicente Bergas
2026-05-07  4:06             ` Sergio Paracuellos
2026-05-07  8:54               ` Linus Walleij
2026-05-07 10:52                 ` Sergio Paracuellos
2026-05-12  0:17                   ` Vicente Bergas
2026-05-14 12:00                     ` Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lddyx7gg.ffs@tglx \
    --to=tglx@kernel.org \
    --cc=anna-maria@linutronix.de \
    --cc=brgl@kernel.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=vicencb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox