From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA0BF1339B1 for ; Sat, 28 Feb 2026 11:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772279066; cv=none; b=o2jmXECKNI2hiq4sWfKlXg4zqOpO4DNi5lA0IJunYa/0NEcNtlbA0chuwXmmcbyo844AoN16TibQjYmAxL4OXe5jCj8gwmv8ZJ01VSQGfaZwamMJ18IjMQVqE0xKNaJb4SIgG6+93q+jvXxQD4mWtLqM0P8uc1xqmW804K7+kEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772279066; c=relaxed/simple; bh=MZnRIGUcBKD1ZzMC2nIziJFNhFQJbnZoUOOTrhjvM18=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=fJLNpCqkRQ/0PMMB9OMOGJ6FivpiYwFPsWyzOzNShLFCtV95ZHS7ND7gdJM8QOu2C6i9Mj+OkVBqmOqhwczHwXo8Lb6MACU9dGnr56Jik1WJ76eYRTlI9OuSRy+FrEDtdk3RwwvqpGdWCwie0r+SPrWb4KOuIt4HkUASu3fJuJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net; spf=pass smtp.mailfrom=posteo.net; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b=CMC5iq29; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b="CMC5iq29" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8C2E7240101 for ; Sat, 28 Feb 2026 12:44:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.net; s=2017; t=1772279061; bh=OiQ3Yebcw45RCZupvgaV4twZnj9RwShWRtrLmqKJBP8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=CMC5iq29tOORdyqhGzq13sV3qgguA1IXKdZWt/bRuQboOiPw9Aw346EoSPuEFRups 7NwpFYstRcMKMUwQPR3/34akskOrMTQTfQyw5JFEySn223NPFiPF8fCOUfWisJX8Rc XT/A/eSbeUCbCED3CK/g1vYMi7hwtVhIrb/TYOwyAguqVPmG+xoFF7pPxx8lFhAEVF L4bIFw4MdF4zX8ULAXtaUP1Sa4t5gUKJgRIXvC2tviJGyb65F+9DFAeIaFroQ8lN8z UrG8ZO8Omtggn8FzeQMAw2IHPAgef/GyMg+a7fd+K/SQPH/h0wPS97diBXUnppKfUW h4EE+yfnK+TBA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4fNNdc20Wwz6tw4; Sat, 28 Feb 2026 12:44:20 +0100 (CET) From: Charalampos Mitrodimas To: Fabio Estevam Cc: heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: dts: rockchip: rk3036: Move PHY reset to ethernet-phy node In-Reply-To: <20260228013257.256973-1-festevam@gmail.com> References: <20260228013257.256973-1-festevam@gmail.com> Date: Sat, 28 Feb 2026 11:44:21 +0000 Message-ID: <87ldgdjdnx.fsf@posteo.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Fabio Estevam writes: > According to rockchip,emac.yaml, 'phy-reset-duration' and 'phy-reset-gpios' > are not valid properties. > > Use the valid 'reset-gpios' and 'reset-assert-us' properties under > the etherne-phy node. > > This fixes the following dt-schema warning: > > Unevaluated properties are not allowed ('phy-reset-duration', > 'phy-reset-gpios' were unexpected) > > Signed-off-by: Fabio Estevam > --- > arch/arm/boot/dts/rockchip/rk3036-evb.dts | 4 ++-- > arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Does this need a "Fixes:" tag (haven't checked)? And could stable benefit from this? Cheers, C. Mitrodimas > > diff --git a/arch/arm/boot/dts/rockchip/rk3036-evb.dts b/arch/arm/boot/dts/rockchip/rk3036-evb.dts > index becdc0b664bf..c8100dc4c7ce 100644 > --- a/arch/arm/boot/dts/rockchip/rk3036-evb.dts > +++ b/arch/arm/boot/dts/rockchip/rk3036-evb.dts > @@ -16,8 +16,6 @@ memory@60000000 { > > &emac { > phy = <&phy0>; > - phy-reset-duration = <10>; /* millisecond */ > - phy-reset-gpios = <&gpio2 RK_PC6 GPIO_ACTIVE_LOW>; /* PHY_RST */ > pinctrl-names = "default"; > pinctrl-0 = <&emac_xfer>, <&emac_mdio>; > status = "okay"; > @@ -28,6 +26,8 @@ mdio { > > phy0: ethernet-phy@0 { > reg = <0>; > + reset-gpios = <&gpio2 RK_PC6 GPIO_ACTIVE_LOW>; > + reset-assert-us = <10000>; > }; > }; > }; > diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > index ae2f84a4e922..bc6e6468fcc4 100644 > --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > @@ -102,8 +102,6 @@ &acodec { > > &emac { > phy = <&phy0>; > - phy-reset-duration = <10>; /* millisecond */ > - phy-reset-gpios = <&gpio2 RK_PC6 GPIO_ACTIVE_LOW>; /* PHY_RST */ > pinctrl-names = "default"; > pinctrl-0 = <&emac_xfer>, <&emac_mdio>; > status = "okay"; > @@ -114,6 +112,8 @@ mdio { > > phy0: ethernet-phy@0 { > reg = <0>; > + reset-gpios = <&gpio2 RK_PC6 GPIO_ACTIVE_LOW>; > + reset-assert-us = <10000>; > }; > }; > };