public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Meghana Malladi <m-malladi@ti.com>, Marc Zyngier <maz@kernel.org>
Cc: MD Danish Anwar <danishanwar@ti.com>,
	Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>,
	Suman Anna <s-anna@ti.com>, David Lechner <david@lechnology.com>,
	Roger Quadros <rogerq@kernel.org>, "Andrew F. Davis" <afd@ti.com>,
	linux-kernel@vger.kernel.org, srk@ti.com, r-gunasekaran@ti.com,
	vigneshr@ti.com
Subject: Re: [PATCH 3/3] irqchip/irq-pruss-intc: Fix processing of IEP interrupts
Date: Sun, 22 Feb 2026 21:59:05 +0100	[thread overview]
Message-ID: <87ldgkwl46.ffs@tglx> (raw)
In-Reply-To: <3486f2bb-439d-4f7e-aad5-8345fba0283b@ti.com>

On Wed, Feb 18 2026 at 16:56, Meghana Malladi wrote:
> On 2/18/26 16:34, Marc Zyngier wrote:
>> I'm sorry, but this comes almost 3 years late, and I've long forgotten
>> about all of this. I can only conclude that if you (TI, not you
>> personally) waited for this long to address my comments, then this is
>> probably not something we really need to care about.
>> 
>
> Thanks for your reply. I understand the concern about the delay and the 
> difficulty in revisiting something after such a long gap.
>
> This work resurfaced now because we are in the process of migrating to 
> the 6.18 LTS kernel, and while validating the migration we encountered 
> these issues again. For our platforms, these fixes are required to get 
> PPS and timestamp functionality working correctly, and for ensuring 
> long-term stability.

For ensuring long-term stability you should work with the upstream
community when changes happen and not wait until you finally catch up
with reality in production.

That's not the way it works. If you ignore feedback for 3 years then you
can't expect that everything is dropped to please you now.

> I realize this comes a long time after the original discussion, but I 
> would like to get the patches into the proper shape and aligned with 
> your feedback. Thanks again for your time and guidance.

Marc told you what he's concerned about and that should be sufficient to
resubmit the patches with proper change logs and comments in the source
code explaining the issue and the solution properly, no?

While at it please fix up the broken S-O-B chain in your submission.
Documentation/process/ explains it neatly. While at it read the rest of
it too and act accordingly.

Thanks,

        tglx

      reply	other threads:[~2026-02-22 20:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  6:18 [PATCH 0/3] Bug Fixes for PRUSS irqchip driver MD Danish Anwar
2023-09-19  6:18 ` [PATCH 1/3] irqchip/irq-pruss-intc: Fix enabling of intc events MD Danish Anwar
2023-09-19  6:18 ` [PATCH 2/3] irqchip/irq-pruss-intc: Fix listed IRQ type in /proc/interrupts MD Danish Anwar
2023-09-19  6:19 ` [PATCH 3/3] irqchip/irq-pruss-intc: Fix processing of IEP interrupts MD Danish Anwar
2023-09-19  7:32   ` Marc Zyngier
2026-02-18  7:08     ` Meghana Malladi
2026-02-18 11:04       ` Marc Zyngier
2026-02-18 11:26         ` Meghana Malladi
2026-02-22 20:59           ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldgkwl46.ffs@tglx \
    --to=tglx@kernel.org \
    --cc=afd@ti.com \
    --cc=danishanwar@ti.com \
    --cc=david@lechnology.com \
    --cc=grzegorz.jaszczyk@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-malladi@ti.com \
    --cc=maz@kernel.org \
    --cc=r-gunasekaran@ti.com \
    --cc=rogerq@kernel.org \
    --cc=s-anna@ti.com \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox