From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49E1918BBAE; Tue, 25 Nov 2025 19:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764097475; cv=none; b=NEVK4mVdOLRx67GdZGZ65DC/dtgoCZIJKT+stMUgbNEkEMjpIecnEhsiVkVAKbv4E8Z3HLqXBhDuI8W0qrciVFXYdNiWYTQY+s5DwvgaQ2N6Y3I1rSUFxS8RfdSR8oPHrB0mRLBXXhon2/KmXiS5eQLxSlEj5sRA+wBlprkouTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764097475; c=relaxed/simple; bh=ohOlxESVUS5GWta7bMITCRe9Q8q5s8Xw6nLN+Y+p9v8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=mSUzd3JGd8+3tiwi9DBtsMN3zR5n9cxrjYVY5KwLG1VwKFImbXUjjz0cocbk0WlQiotT3rMyvHxop9UqRyimWoeK+Ph5UJEehN3dZaEwjvFcHw/JpX4yVOXZpQQbDqxri96LyR/aEHGiAV8bNw2im9OK3UQ1TWBOJ213b2d+RXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=Xyhd4zGS; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=kWYpqVqO; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Xyhd4zGS"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kWYpqVqO" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1764097472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UoGHYDHwZQQrMcaSIQuTum0d3CDmwrfoU7AaJG27DpI=; b=Xyhd4zGSpk2YthZrTiDfaXBNQHuvNqYg2oKJEpKnl2a9+IaKQhCVytVHBfrbSZOc5UNVdt w1Hp+r+3TMChKtEOe7ZBheF8e0ajR/pfyGCv6xS+LabTtkWrF0WTdGdxklgfjRI9U0bc3g l+s+zBxODv3LTPYPK0pJtAf++IjuXAnbPDKDHLclCeyNAn1UBSrmU4wTywbBMw4gj1VMB6 yP0DWATdGflfmJXD8SbbXStNK6ZSQzp8+4LriNk0GcUMAr4viGLVyIxfkFJi0q+MrAmq0c gwc8emA6AF8GTJJxsGxj2Y83lOgky7oSqU7OYP8treadaQb3pPz8PARNnYtxDw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1764097472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UoGHYDHwZQQrMcaSIQuTum0d3CDmwrfoU7AaJG27DpI=; b=kWYpqVqOOOeG44/5ESzHmjCOIT0/1+E6Xwk4rHPo72nuBG+g/nPyHLfLlvpcQPvBNgP7vT ecrOGNuno3Or8gCw== To: Luigi Rizzo Cc: LKML , x86@kernel.org, stable@vger.kernel.org, Lu Baolu , Joerg Roedel Subject: Re: [patch 1/3] x86/msi: Make irq_retrigger() functional for posted MSI In-Reply-To: References: <20251125101912.564125647@linutronix.de> <20251125102000.636453530@linutronix.de> Date: Tue, 25 Nov 2025 20:04:31 +0100 Message-ID: <87ldjugchs.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Nov 25 2025 at 18:54, Luigi Rizzo wrote: > On Tue, Nov 25, 2025 at 11:20=E2=80=AFAM Thomas Gleixner wrote: >> >> Luigi reported that retriggering a posted MSI interrupt does not work >> correctly. >> [...] >> >> So instead of playing games with the PIR, this can be actually solved >> for both cases by: >> >> 1) Keeping track of the posted interrupt vector handler state > > Tangential comment, but I see that this patch uses this_cpu_read()/write() > whereas the rest of the file uses __this_cpu_read()/write() You're right. I've missed that. Let me redo it.