From: Thomas Gleixner <tglx@linutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Agustin Vega-Frias" <agustinv@codeaurora.org>,
"Marc Zyngier" <maz@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Markus Schneider-Pargmann <msp@baylibre.com>
Subject: Re: [PATCH] irqchip/qcom-irq-combiner: Rename driver struct to end in _driver
Date: Mon, 30 Jun 2025 20:01:53 +0200 [thread overview]
Message-ID: <87ldp9m7la.ffs@tglx> (raw)
In-Reply-To: <20250630172333.73614-2-u.kleine-koenig@baylibre.com>
On Mon, Jun 30 2025 at 19:23, Uwe Kleine-König wrote:
> The modpost section mismatch checks are more lax for objects that have a
> name that ends in "_probe". This is not justified here though, so rename
That's a truly bad design or lack of such.
Why can't this muck use foo_driver(name) foo_probe(name) annotations to
make it entirely clear what is tested for instead of oracling it out of
the name itself. That would make it too easy to understand and analyse.
Sigh...
Thanks,
tglx
next prev parent reply other threads:[~2025-06-30 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 17:23 [PATCH] irqchip/qcom-irq-combiner: Rename driver struct to end in _driver Uwe Kleine-König
2025-06-30 17:25 ` Konrad Dybcio
2025-06-30 18:31 ` Jeff Hugo
2025-07-01 7:40 ` Konrad Dybcio
2025-07-01 14:34 ` Jeff Hugo
2025-06-30 18:01 ` Thomas Gleixner [this message]
2025-06-30 19:40 ` Uwe Kleine-König
2025-07-01 9:01 ` Thomas Gleixner
2025-07-01 13:58 ` Uwe Kleine-König
2025-07-01 14:24 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldp9m7la.ffs@tglx \
--to=tglx@linutronix.de \
--cc=agustinv@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=msp@baylibre.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).