From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext4: remove unnecessary duplicate check in ext4_map_blocks()
Date: Sat, 24 May 2025 10:07:33 +0530 [thread overview]
Message-ID: <87ldqm39pu.fsf@gmail.com> (raw)
In-Reply-To: <aDCdjUhpzxB64vkD@stanley.mountain>
Dan Carpenter <dan.carpenter@linaro.org> writes:
> The previous lines ensure that EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF is
> set so remove this duplicate check.
>
Earlier, I knew it was a redundant check, but I went ahead with it
anyway; and later, I might have missed removing it. I agree that we
don’t really need this extra check.
So, the patch looks good to me. Thanks for taking care of it!
Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> fs/ext4/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index be9a4cba35fd..014021019b22 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -757,8 +757,7 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
> orig_mlen == map->m_len)
> goto found;
>
> - if (flags & EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF)
> - map->m_len = orig_mlen;
> + map->m_len = orig_mlen;
> }
> /*
> * In the query cache no-wait mode, nothing we can do more if we
> --
> 2.47.2
prev parent reply other threads:[~2025-05-24 4:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 16:08 [PATCH] ext4: remove unnecessary duplicate check in ext4_map_blocks() Dan Carpenter
2025-05-24 4:37 ` Ritesh Harjani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldqm39pu.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox