public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Kailang <kailang@realtek.com>, Takashi Iwai <tiwai@suse.de>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable PC beep passthrough for HP EliteBook 855 G7
Date: Mon, 03 Mar 2025 13:45:13 +0100	[thread overview]
Message-ID: <87ldtme10m.wl-tiwai@suse.de> (raw)
In-Reply-To: <2fea9fe8-312f-45a0-9bed-455c910fba43@maciej.szmigiero.name>

On Wed, 19 Feb 2025 12:16:35 +0100,
Maciej S. Szmigiero wrote:
> 
> Hi Kailang,
> 
> On 19.02.2025 09:32, Kailang wrote:
> > 
> > Hi Maciej S,
> >     Could you test plug headphone then speaker will mute or not?
> >     Below was why I close the beep mode.
> >   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=fcf c9f711d1e2fc7876ac12b1b16c509404b9625
> 
> 
> When I plug headphones then both normal sound playback (ALSA) and PC beep move to headphones.
> The main laptop speaker gets muted indeed.
> 
> I'm testing on kernel 6.12 so the Dell patch above is included.
> 
> >   Hi Takashi,
> >     COEF 0x36 bit 13 was the enable bit for pcbeep passthrough for
> > 0x14.
> >   If this patch no PM issues and speaker can mute by plug headphone or headset,
> >   I think this work for me.
> > 
> 
> Nice, thanks for clarifying.

So, Kailang, is Maciej's patch OK to take from Realtek POV?

If so, feel free to give an Acked-by tag or such for the upstream
inclusion.


thanks,

Takashi

  reply	other threads:[~2025-03-03 12:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-16 21:31 [PATCH v2] ALSA: hda/realtek: Enable PC beep passthrough for HP EliteBook 855 G7 Maciej S. Szmigiero
2025-02-17 10:02 ` Takashi Iwai
2025-02-17 10:11   ` Jaroslav Kysela
2025-02-17 10:17   ` Maciej S. Szmigiero
2025-02-17 10:52     ` Takashi Iwai
2025-02-17 13:18       ` Maciej S. Szmigiero
2025-02-19  8:27       ` Kailang
2025-02-19  8:32       ` Kailang
2025-02-19 11:16         ` Maciej S. Szmigiero
2025-03-03 12:45           ` Takashi Iwai [this message]
2025-03-04  6:26             ` Kailang
2025-03-04  8:30               ` Takashi Iwai
2025-02-19  8:39       ` Kailang
2025-02-19  6:00   ` Kailang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldtme10m.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox