From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10D9C1BD9F2 for ; Tue, 21 Jan 2025 12:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737461159; cv=none; b=vCOPGUM+ZtUmAZGbBWxRAnLlUK5ddlCEXqAr03Gas4KMeYZb7XcdekwpS0uNYy3PCHskcx6e5ipFC3zBcE1Gi76DeV7w6JA4RNLsksolq73gLWx+gVwXjkDABuKPOmYrbW1mOblWN+39bnyS+dslA/e8zWLdiG17pWpuv110OZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737461159; c=relaxed/simple; bh=5ZOTaWU0pr3Lkza45u81StZ/TTvBCTMGO3w3mo/GCRI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ZWUWIa6bWFiNqyW7hfC9B/LTBQRsvlviCGM8V4kYQHQ/LDc/zpNdxr/gmJ2ir3Sf/QYrasmDcW6FeZdGwIzneuN/UjBzO/+gQao97T2HQl2CjxxQhDucEyU8BdWWRyngNYWHWJpovRsYg4tmYAb5pzx/dw0m8wacCsiKxuLjw6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dETKtRtt; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dETKtRtt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737461157; x=1768997157; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=5ZOTaWU0pr3Lkza45u81StZ/TTvBCTMGO3w3mo/GCRI=; b=dETKtRttwBf2H4W8mNAFQEdYFrSlbAe3MNmbdMqk4dgdJqMHf16F/aBZ o74xe+CGzJ80/nOmF8P6frLVs0lbEz1eR51LxEcFB45HmEtlFfwFvc5ZS EThthrwA7Ok3Y9R+ln8vv5juuw8UtoOs0gcpbzGeVjoz3wed5Wp/hUu2G JcHCnfuhp95O8zMio7CUKvNF75lIi2PB1haLxd7pSgLHjAPfQ03iVSLcL q4MeokBr2BSugKjh24Gr2/DLZP+Yx9fluy0KRU9eSPnTHSxqJMyv0Zmvk hRZUeyh7nlNHv/vSH5SiJJLSidG0SogOB4jESmTFFR4rB4rO9ivkgI7Hs w==; X-CSE-ConnectionGUID: F9VapNcxRBmsefJ2s5S0UQ== X-CSE-MsgGUID: +OpbhK6wTCC+yUaxgAG/qw== X-IronPort-AV: E=McAfee;i="6700,10204,11321"; a="41627742" X-IronPort-AV: E=Sophos;i="6.13,222,1732608000"; d="scan'208";a="41627742" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2025 04:05:56 -0800 X-CSE-ConnectionGUID: 7t2LdGxxR2uicw5lGtmolw== X-CSE-MsgGUID: pqHbNiEgQtaAHWqjMY0kAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="130069645" Received: from mklonows-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.186]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2025 04:05:52 -0800 From: Jani Nikula To: Atharva Tiwari Cc: evepolonium@gmail.com, Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ville Syrjala Subject: Re: [PATCH] drm/i915/fbdev: Discard large BIOS framebuffers In-Reply-To: <20250121104210.3159-1-evepolonium@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250121104210.3159-1-evepolonium@gmail.com> Date: Tue, 21 Jan 2025 14:05:49 +0200 Message-ID: <87ldv4pe1u.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, 21 Jan 2025, Atharva Tiwari wrote: > On certain 4K panels, the BIOS framebuffer > exceeds the panel's required dimensions, > leading to display corruption. > This patch introduces a validation check to address the issue. > > Signed-off-by: Atharva Tiwari See [1], [2], and [3]. Please add your dmesg with debugs enabled to [3]. BR, Jani. [1] https://lore.kernel.org/r/31D69334-DEF9-41B7-968B-B847796926FF@outlook.com [2] https://lore.kernel.org/r/Yd7ZnBlU0sjP4qcG@intel.com [3] https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13466 > --- > drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > index 00852ff5b247..e8cf06772c31 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > @@ -197,10 +197,10 @@ static int intelfb_create(struct drm_fb_helper *helper, > ifbdev->fb = NULL; > > if (fb && > - (sizes->fb_width > fb->base.width || > - sizes->fb_height > fb->base.height)) { > + (sizes->fb_width != fb->base.width || > + sizes->fb_height != fb->base.height)) { > drm_dbg_kms(&dev_priv->drm, > - "BIOS fb too small (%dx%d), we require (%dx%d)," > + "BIOS fb dimensions mismatch (%dx%d), we require (%dx%d)," > " releasing it\n", > fb->base.width, fb->base.height, > sizes->fb_width, sizes->fb_height); -- Jani Nikula, Intel