From: Marc Zyngier <maz@kernel.org>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-kernel@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] irqchip/renesas-rzg2l: Fix missing put_device
Date: Mon, 30 Sep 2024 16:50:28 +0100 [thread overview]
Message-ID: <87ldz9uomz.wl-maz@kernel.org> (raw)
In-Reply-To: <20240930145539.357573-1-fabrizio.castro.jz@renesas.com>
On Mon, 30 Sep 2024 15:55:39 +0100,
Fabrizio Castro <fabrizio.castro.jz@renesas.com> wrote:
>
> rzg2l_irqc_common_init calls of_find_device_by_node, but the
> corresponding put_device call is missing.
>
> Make sure we call put_device both when failing and when
> succeeding.
What sort of lifetime are you trying to enforce?
It looks to me that you'd be better off doing *one* device_put() right
after you have found the parent domain, but that completely depends on
the above.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2024-09-30 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 14:55 [PATCH] irqchip/renesas-rzg2l: Fix missing put_device Fabrizio Castro
2024-09-30 15:50 ` Marc Zyngier [this message]
2024-09-30 16:36 ` Fabrizio Castro
2024-09-30 19:14 ` Marc Zyngier
2024-10-01 11:54 ` Fabrizio Castro
2024-10-06 15:53 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldz9uomz.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox