From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9987189BAC; Mon, 30 Sep 2024 15:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727711438; cv=none; b=ELzi9j/LV3CZwbO1UCciRPrSMVzEbc7lS7b8pf9r6u+X1lVLWaVzlS8WHgitrH7hfI2/Ex67YVDFGYl/PqTJsugmPfQOHMP3KC/Q/AjyMgR6R99GDyViha+lAEZKqS/kCmg27nnfXeNjLEUT2yluLhYiTAX+Pe97eHRAFgzeJ5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727711438; c=relaxed/simple; bh=XwQufWlA9oOR+zahrhG9fBrbWA0VGgrx+eSGo9UFqNs=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=BcGPFaM789NLS6EY5R9d2kKZHuHsBTAp51vdyNdGDHv0Cu7e97tqUReS4h/MR3j63+fsXt5tqqfPa3TjZPHm8FRl21VjyCerqfz6iMQyBZ92r33umt7753IWB0BcDC+E3FF912QWEUg7ImaEXc5d7lH9aTMqmIXSItj/4TrTmuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lqcWCMVk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lqcWCMVk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D825C4CECE; Mon, 30 Sep 2024 15:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727711437; bh=XwQufWlA9oOR+zahrhG9fBrbWA0VGgrx+eSGo9UFqNs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lqcWCMVkzrKlEEXiaZTLyBxgaphw9xPGgJS/z/q78CGMshzzoau/Tr156kP20mK6p HkQaHVUk0otEuTdFuHSp0yZsRGT38M+YgifiDReWRppfoqp/gSpQialSZBjpKscBbZ oIjhDXGdgzzxP4PO2eLMpsUoUrCTaDCe/2qI4ekBRwXFPItzvT3mAxXKetwENBIKxm 6fr+xbjVUFIb9p12NHNUttjzA/25JQhqkhpOsWey3DNIMlMTTxzYALGWBc2Y/bAdVS PmrlhkQ90BzaxWrexYAmANnw9bGeDBP/SzITU8niWMgasWNXh/8AEGCVE2TvnPwpT3 oBKkY92o5z2Xg== Received: from [104.132.1.106] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1svIfS-00GUXu-UO; Mon, 30 Sep 2024 16:50:35 +0100 Date: Mon, 30 Sep 2024 16:50:28 +0100 Message-ID: <87ldz9uomz.wl-maz@kernel.org> From: Marc Zyngier To: Fabrizio Castro Cc: Thomas Gleixner , Geert Uytterhoeven , Lad Prabhakar , linux-kernel@vger.kernel.org, Chris Paterson , Biju Das , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] irqchip/renesas-rzg2l: Fix missing put_device In-Reply-To: <20240930145539.357573-1-fabrizio.castro.jz@renesas.com> References: <20240930145539.357573-1-fabrizio.castro.jz@renesas.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 104.132.1.106 X-SA-Exim-Rcpt-To: fabrizio.castro.jz@renesas.com, tglx@linutronix.de, geert+renesas@glider.be, prabhakar.mahadev-lad.rj@bp.renesas.com, linux-kernel@vger.kernel.org, Chris.Paterson2@renesas.com, biju.das.jz@bp.renesas.com, linux-renesas-soc@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 30 Sep 2024 15:55:39 +0100, Fabrizio Castro wrote: > > rzg2l_irqc_common_init calls of_find_device_by_node, but the > corresponding put_device call is missing. > > Make sure we call put_device both when failing and when > succeeding. What sort of lifetime are you trying to enforce? It looks to me that you'd be better off doing *one* device_put() right after you have found the parent domain, but that completely depends on the above. Thanks, M. -- Without deviation from the norm, progress is not possible.