* [PATCH] drm: have config DRM_WERROR depend on !WERROR
@ 2024-05-16 8:33 Jani Nikula
2024-05-16 12:36 ` Sui Jingfeng
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2024-05-16 8:33 UTC (permalink / raw)
To: dri-devel; +Cc: linux-kernel, airlied, Jani Nikula, Linus Torvalds
If WERROR is already enabled, there's no point in enabling DRM_WERROR or
asking users about it.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 026444eeb5c6..d0aa277fc3bf 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -450,6 +450,7 @@ config DRM_PRIVACY_SCREEN
config DRM_WERROR
bool "Compile the drm subsystem with warnings as errors"
depends on DRM && EXPERT
+ depends on !WERROR
default n
help
A kernel build should not cause any compiler warnings, and this
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: drm: have config DRM_WERROR depend on !WERROR
2024-05-16 8:33 [PATCH] drm: have config DRM_WERROR depend on !WERROR Jani Nikula
@ 2024-05-16 12:36 ` Sui Jingfeng
2024-06-07 12:24 ` [PATCH] " Jani Nikula
2024-06-07 12:37 ` Javier Martinez Canillas
2 siblings, 0 replies; 5+ messages in thread
From: Sui Jingfeng @ 2024-05-16 12:36 UTC (permalink / raw)
To: Jani Nikula, dri-devel; +Cc: linux-kernel, airlied, Linus Torvalds
Hi,
On 5/16/24 16:33, Jani Nikula wrote:
> If WERROR is already enabled, there's no point in enabling DRM_WERROR or
> asking users about it.
>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
> Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Wow, you successfully get Linus's attention, haha.
> ---
> drivers/gpu/drm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 026444eeb5c6..d0aa277fc3bf 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -450,6 +450,7 @@ config DRM_PRIVACY_SCREEN
> config DRM_WERROR
> bool "Compile the drm subsystem with warnings as errors"
> depends on DRM && EXPERT
> + depends on !WERROR
> default n
> help
> A kernel build should not cause any compiler warnings, and this
--
Best regards
Sui
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR
2024-05-16 8:33 [PATCH] drm: have config DRM_WERROR depend on !WERROR Jani Nikula
2024-05-16 12:36 ` Sui Jingfeng
@ 2024-06-07 12:24 ` Jani Nikula
2024-06-07 12:37 ` Javier Martinez Canillas
2 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2024-06-07 12:24 UTC (permalink / raw)
To: dri-devel; +Cc: linux-kernel, airlied, Linus Torvalds
On Thu, 16 May 2024, Jani Nikula <jani.nikula@intel.com> wrote:
> If WERROR is already enabled, there's no point in enabling DRM_WERROR or
> asking users about it.
Ping. Any comments? (Besides the one snark.)
BR,
Jani.
>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
> Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 026444eeb5c6..d0aa277fc3bf 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -450,6 +450,7 @@ config DRM_PRIVACY_SCREEN
> config DRM_WERROR
> bool "Compile the drm subsystem with warnings as errors"
> depends on DRM && EXPERT
> + depends on !WERROR
> default n
> help
> A kernel build should not cause any compiler warnings, and this
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR
2024-05-16 8:33 [PATCH] drm: have config DRM_WERROR depend on !WERROR Jani Nikula
2024-05-16 12:36 ` Sui Jingfeng
2024-06-07 12:24 ` [PATCH] " Jani Nikula
@ 2024-06-07 12:37 ` Javier Martinez Canillas
2024-06-07 14:44 ` Jani Nikula
2 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2024-06-07 12:37 UTC (permalink / raw)
To: Jani Nikula, dri-devel; +Cc: linux-kernel, airlied, Jani Nikula, Linus Torvalds
Jani Nikula <jani.nikula@intel.com> writes:
Hello Jani,
> If WERROR is already enabled, there's no point in enabling DRM_WERROR or
> asking users about it.
>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
> Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
The change makes sense to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR
2024-06-07 12:37 ` Javier Martinez Canillas
@ 2024-06-07 14:44 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2024-06-07 14:44 UTC (permalink / raw)
To: Javier Martinez Canillas, dri-devel; +Cc: linux-kernel, airlied, Linus Torvalds
On Fri, 07 Jun 2024, Javier Martinez Canillas <javierm@redhat.com> wrote:
> Jani Nikula <jani.nikula@intel.com> writes:
>
> Hello Jani,
>
>> If WERROR is already enabled, there's no point in enabling DRM_WERROR or
>> asking users about it.
>>
>> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
>> Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
>> Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>
> The change makes sense to me.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks, pushed to drm-misc-fixes.
BR,
Jani.
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-07 14:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 8:33 [PATCH] drm: have config DRM_WERROR depend on !WERROR Jani Nikula
2024-05-16 12:36 ` Sui Jingfeng
2024-06-07 12:24 ` [PATCH] " Jani Nikula
2024-06-07 12:37 ` Javier Martinez Canillas
2024-06-07 14:44 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox