Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR

Jani Nikula
2024-06-07T12:24:06Z

On Thu, 16 May 2024, Jani Nikula <jani.nikula@intel.com> wrote:
> If WERROR is already enabled, there's no point in enabling DRM_WERROR or
> asking users about it.

Ping. Any comments? (Besides the one snark.)

BR,
Jani.

>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Closes: https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com
> Fixes: f89632a9e5fa ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 026444eeb5c6..d0aa277fc3bf 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -450,6 +450,7 @@ config DRM_PRIVACY_SCREEN
> config DRM_WERROR
> bool "Compile the drm subsystem with warnings as errors"
> depends on DRM && EXPERT
> + depends on !WERROR
> default n
> help
> A kernel build should not cause any compiler warnings, and this

--
Jani Nikula, Intel