public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
	<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ALSA: hda: cirrus_scodec: Select GPIOLIB for KUnit test
Date: Wed, 20 Sep 2023 11:20:16 +0200	[thread overview]
Message-ID: <87led1urov.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230920090338.29345-1-rf@opensource.cirrus.com>

On Wed, 20 Sep 2023 11:03:38 +0200,
Richard Fitzgerald wrote:
> 
> The KUnit test for cirrus_scodec uses GPIO library functions so select
> GPIOLIB in Kconfig.
> 
> This fixes the ld failures on builds that didn't already select GPIOLIB.
>  ld: vmlinux.o: in function `cirrus_scodec_test_gpio_get':
>  sound/pci/hda/cirrus_scodec_test.c:40: undefined reference to
> 	`gpiochip_get_data'
>  ld: vmlinux.o: in function `cirrus_scodec_test_gpio_probe':
>  sound/pci/hda/cirrus_scodec_test.c:94: undefined reference to
> 	`gpiochip_generic_request'
>  ld: sound/pci/hda/cirrus_scodec_test.c:94: undefined reference to
> 	`gpiochip_generic_free'
>  ld: sound/pci/hda/cirrus_scodec_test.c:95: undefined reference to
> 	`devm_gpiochip_add_data_with_key'
> 
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309201646.NnjfKPWk-lkp@intel.com/
> Fixes: 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test")

Thanks, applied now.


Takashi

      reply	other threads:[~2023-09-20  9:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  9:03 [PATCH] ALSA: hda: cirrus_scodec: Select GPIOLIB for KUnit test Richard Fitzgerald
2023-09-20  9:20 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87led1urov.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox