From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A176CE79AB for ; Wed, 20 Sep 2023 09:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233793AbjITJU1 (ORCPT ); Wed, 20 Sep 2023 05:20:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232318AbjITJUY (ORCPT ); Wed, 20 Sep 2023 05:20:24 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9103093 for ; Wed, 20 Sep 2023 02:20:18 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 50C7A22289; Wed, 20 Sep 2023 09:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695201617; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jbbGch/Q6HVLRHkYXyo2S8jneaurE4SIb9nFvhy/6gI=; b=iMkzUEInCexmZiRYaYpiG+g9/YGV6iXXrwykmYa4XgglV23nD7zxdeOBZOyxfPFVs1+b2P /vVaHsLK2EDUQLQQhWgUur497XbJJbT6lUYBRnTxWbAo9y1SiAsdqSnoxfBkGCJPZc0C7h oXqxAfX9loiHyQ5CLBd/becvcvt3ar8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695201617; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jbbGch/Q6HVLRHkYXyo2S8jneaurE4SIb9nFvhy/6gI=; b=8lRH7N3Qy8AvnPPrXnCmFsgvnqYroFFstpu248A0+rqwGGOhmhQSks3/fC0I3zWpedGQoX rRZP+Tw8vEheuNCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D5521333E; Wed, 20 Sep 2023 09:20:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EQAHBlG5CmXCcQAAMHmgww (envelope-from ); Wed, 20 Sep 2023 09:20:17 +0000 Date: Wed, 20 Sep 2023 11:20:16 +0200 Message-ID: <87led1urov.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , , kernel test robot Subject: Re: [PATCH] ALSA: hda: cirrus_scodec: Select GPIOLIB for KUnit test In-Reply-To: <20230920090338.29345-1-rf@opensource.cirrus.com> References: <20230920090338.29345-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Sep 2023 11:03:38 +0200, Richard Fitzgerald wrote: > > The KUnit test for cirrus_scodec uses GPIO library functions so select > GPIOLIB in Kconfig. > > This fixes the ld failures on builds that didn't already select GPIOLIB. > ld: vmlinux.o: in function `cirrus_scodec_test_gpio_get': > sound/pci/hda/cirrus_scodec_test.c:40: undefined reference to > `gpiochip_get_data' > ld: vmlinux.o: in function `cirrus_scodec_test_gpio_probe': > sound/pci/hda/cirrus_scodec_test.c:94: undefined reference to > `gpiochip_generic_request' > ld: sound/pci/hda/cirrus_scodec_test.c:94: undefined reference to > `gpiochip_generic_free' > ld: sound/pci/hda/cirrus_scodec_test.c:95: undefined reference to > `devm_gpiochip_add_data_with_key' > > Signed-off-by: Richard Fitzgerald > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202309201646.NnjfKPWk-lkp@intel.com/ > Fixes: 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test") Thanks, applied now. Takashi