From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AFB7C83F22 for ; Wed, 30 Aug 2023 19:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241187AbjH3TKN (ORCPT ); Wed, 30 Aug 2023 15:10:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245419AbjH3PMQ (ORCPT ); Wed, 30 Aug 2023 11:12:16 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1F8CE8 for ; Wed, 30 Aug 2023 08:12:13 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9231D1F45F; Wed, 30 Aug 2023 15:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1693408332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t40XEzRpGZfp8+6J4H0kh7K0iLROTuGTa5ymi1tx/M0=; b=gRw3ufwXH6OqCSLN/K6J41i6LBXT7DwyDRBuMPqUJE4gATTr0RORMpbcwMGVZ6eD4srqXS CQypot+pjPbmJ+0bhTW/tb1x9OpOuEKmPq0adD6JrYigOc0qJwumOjkwTZK6XK3XDnEvB7 z/K5QSEyGNob4fkRRVHDf/1tHhoVUTc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1693408332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t40XEzRpGZfp8+6J4H0kh7K0iLROTuGTa5ymi1tx/M0=; b=rK20637WNo/ZH/uBEcLA79DHUR4xqEXK41LWHUt1E8q/X8U2TfD7EpambQLfPE4q6GYX6L RCsZNREfUBYi5wAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 701A71353E; Wed, 30 Aug 2023 15:12:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /sraGkxc72RzJgAAMHmgww (envelope-from ); Wed, 30 Aug 2023 15:12:12 +0000 Date: Wed, 30 Aug 2023 17:12:12 +0200 Message-ID: <87ledsfttf.wl-tiwai@suse.de> From: Takashi Iwai To: Charles Keepax Cc: "Sudip Mukherjee (Codethink)" , James Schulman , David Rhodes , "Richard Fitzgerald" , Lee Jones , , , , Linus Torvalds , Subject: Re: mainline build failure due to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver") In-Reply-To: <20230830150037.GW103419@ediswmail.ad.cirrus.com> References: <87cyz4he2u.wl-tiwai@suse.de> <20230830150037.GW103419@ediswmail.ad.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Aug 2023 17:00:37 +0200, Charles Keepax wrote: > > On Wed, Aug 30, 2023 at 03:09:13PM +0200, Takashi Iwai wrote: > > On Wed, 30 Aug 2023 13:29:57 +0200, > > Sudip Mukherjee (Codethink) wrote: > > > > > > Hi All, > > > > > > The latest mainline kernel branch fails to build alpha, csky and s390 > > > allmodconfig with the error: > > > > > > drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function] > > > 1138 | static int cs42l43_runtime_resume(struct device *dev) > > > | ^~~~~~~~~~~~~~~~~~~~~~ > > > drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function] > > > 1124 | static int cs42l43_runtime_suspend(struct device *dev) > > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > > drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function] > > > 1106 | static int cs42l43_resume(struct device *dev) > > > | ^~~~~~~~~~~~~~ > > > drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function] > > > 1076 | static int cs42l43_suspend(struct device *dev) > > > | ^~~~~~~~~~~~~~~ > > > > > > git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver") > > > > > > I will be happy to test any patch or provide any extra log if needed. > > > > Adding __maybe_unused for those PM functions should work around it, > > something like below. Could you check it? > > If it's confirmed to work, I'll submit properly. > > > > > > This is probably the correct fix: > > https://lore.kernel.org/lkml/20230822114914.340359-1-ckeepax@opensource.cirrus.com/ > > Just waiting on it to be reviewed. Thanks, that looks better. Let's wait for the patch acceptance. Takashi