From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v2 2/8] printk: Provide debug_store() for nbcon debugging
Date: Fri, 28 Jul 2023 23:07:08 +0206 [thread overview]
Message-ID: <87leez92ej.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <ZMPdRVXq3IybuvzN@alley>
On 2023-07-28, Petr Mladek <pmladek@suse.com> wrote:
>> + r = vprintk_store(2, 7, NULL, fmt, args);
>
> We should probably use one of the LOG_LOCALX numbers, e.g.
>
> #define LOG_LOCAL0 (16<<3)
>
> Also, please use LOGLEVEL_DEBUG instead of the hard coded "7".
OK.
I am also open to dropping the function and its use. When developing the
ringbuffer I also had a similar function but never attempted to publish
it. It is useful for developing/testing/debugging, but once everything
works as it should it has no real purpose. I have no problems keeping
the debug stuff hidden in my own private toolbox.
John
next prev parent reply other threads:[~2023-07-28 21:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 0:02 [PATCH printk v2 0/8] wire up nbcon consoles John Ogness
2023-07-28 0:02 ` [PATCH printk v2 1/8] printk: Add non-BKL (nbcon) console basic infrastructure John Ogness
2023-07-28 14:47 ` Petr Mladek
2023-07-28 20:51 ` John Ogness
2023-07-31 15:39 ` Petr Mladek
2023-07-31 20:39 ` John Ogness
2023-08-01 10:35 ` Petr Mladek
2023-07-28 0:02 ` [PATCH printk v2 2/8] printk: Provide debug_store() for nbcon debugging John Ogness
2023-07-28 9:52 ` John Ogness
2023-07-28 15:22 ` Petr Mladek
2023-07-28 21:01 ` John Ogness [this message]
2023-07-31 15:43 ` Petr Mladek
2023-07-28 0:02 ` [PATCH printk v2 3/8] printk: nbcon: Add acquire/release logic John Ogness
2023-08-09 10:20 ` Petr Mladek
2023-08-29 9:43 ` John Ogness
2023-08-09 12:44 ` hostile takeover: " Petr Mladek
2023-08-29 10:22 ` John Ogness
2023-09-07 15:40 ` Petr Mladek
2023-09-08 14:48 ` John Ogness
2023-07-28 0:02 ` [PATCH printk v2 4/8] printk: nbcon: Add buffer management John Ogness
2023-08-09 14:06 ` Petr Mladek
2023-07-28 0:02 ` [PATCH printk v2 5/8] printk: nbcon: Add sequence handling John Ogness
2023-07-28 1:33 ` kernel test robot
2023-07-28 9:00 ` John Ogness
2023-08-10 9:28 ` Petr Mladek
2023-08-29 11:51 ` John Ogness
2023-07-28 0:02 ` [PATCH printk v2 6/8] printk: nbcon: Add ownership state functions John Ogness
2023-08-10 12:56 ` Petr Mladek
2023-08-29 12:23 ` John Ogness
2023-07-28 0:02 ` [PATCH printk v2 7/8] printk: nbcon: Add emit function and callback function for atomic printing John Ogness
2023-08-11 13:37 ` Petr Mladek
2023-08-29 13:08 ` John Ogness
2023-07-28 0:02 ` [PATCH printk v2 8/8] printk: nbcon: Add functions for drivers to mark unsafe regions John Ogness
2023-08-11 13:50 ` Petr Mladek
2023-08-29 13:13 ` John Ogness
2023-08-11 13:56 ` [PATCH printk v2 0/8] wire up nbcon consoles Petr Mladek
2023-08-29 13:21 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leez92ej.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox